Disable TransformSubnetTx post-Etna
#3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
marun
reviewed
Jun 26, 2024
|
The e2e failure appears legit. Maybe worth enabling e2e runs against different rulesets (i.e. #2666) in advance of the E upgrade? |
I've deleted the test for now... I think we'll need to start thinking about testing different rulesets for the E Upgrade Not super concerned with this specific one because this functionality isn't used by anybody on Mainnet but if there's a good way to restore the e2e I would definitely prefer that |
marun
reviewed
Jun 26, 2024
marun
reviewed
Jun 26, 2024
marun
reviewed
Aug 5, 2024
marun
approved these changes
Aug 5, 2024
dhrubabasu
changed the title
TransformSubnetTx after EUpgrade activationTransformSubnetTx post-Etna
dhrubabasu
changed the title
TransformSubnetTx post-EtnaTransformSubnetTx post-Etna
StephenButtolph
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Per ACP-77:
How this works
Marks
TransformSubnetTxas invalid after EUpgrade is activatedHow this was tested
Added UT