Remove memsize #642
Merged
Remove memsize #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per pull request ethereum/go-ethereum#30253, memsize doesn't work on go 1.23 Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
darioush
approved these changes
Aug 22, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
As per pull request ethereum/go-ethereum#30253, memsize doesn't work on go 1.23 Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per pull request ethereum/go-ethereum#30253, memsize doesn't work on go 1.23
Why this should be merged
Coreth cannot work with Go 1.23 because of it breaks a dependency. The above pull request removes the dependency.
How this works
Removes some code that uses a dependency, as per the official ethereum change.
How this was tested
CI would hopefully pass.