Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/debug: remove memsize #30253

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Aug 1, 2024

Removing because memsize will very likely be broken by Go 1.23. See fjl/memsize#4

Removing because memsize will very likely be broken by Go 1.23.
See fjl/memsize#4
@fjl fjl added this to the 1.14.8 milestone Aug 1, 2024
@fjl fjl merged commit e467577 into ethereum:master Aug 2, 2024
2 checks passed
leeren pushed a commit to storyprotocol/story-geth that referenced this pull request Aug 16, 2024
Removing because memsize will very likely be broken by Go 1.23. See
fjl/memsize#4
yacovm added a commit to yacovm/coreth that referenced this pull request Aug 22, 2024
As per pull request ethereum/go-ethereum#30253,
memsize doesn't work on go 1.23

Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
darioush pushed a commit to ava-labs/coreth that referenced this pull request Aug 22, 2024
As per pull request ethereum/go-ethereum#30253,
memsize doesn't work on go 1.23

Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
darioush pushed a commit to ava-labs/subnet-evm that referenced this pull request Aug 27, 2024
As per pull request ethereum/go-ethereum#30253,
memsize doesn't work on go 1.23

Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
darioush pushed a commit to ava-labs/subnet-evm that referenced this pull request Aug 27, 2024
As per pull request ethereum/go-ethereum#30253,
memsize doesn't work on go 1.23

Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants