-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: build with go1.23 #217
Conversation
b381fb7
to
a3d0731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@joshuasing as long as this passes this is an approval from me ✅ https://github.com/hemilabs/heminetwork/actions/runs/10496216883 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @joshuasing it seems that this breaks localnet tests
https://github.com/hemilabs/heminetwork/actions/runs/10496216883/job/29076358690#step:5:4833
90.37 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
90.57 util.go:48: exit status 1
90.57 exit status 1
90.63 make: *** [Makefile:12: geth] Error 1
can we fix this before merge? I am happy to look as well
Reverted to Go 1.22.6 in fjl/memsize#4 |
Summary
Build project with Go v1.23.
This does not change the
go
directive in thego.mod
files, meaning we do not require consumers of this module to usego1.23
, and we cannot use Go v1.23 features yet.Changes
go1.23
1.23.x
in GitHub Actions1.23-alpine3.20
and1.23-bookworm
(debian)Note: Go v1.23 introduces new
go vet
checks for theslices
package which are currently failing, resolved by #215