Multi-Profile Support #81
Conversation
| final var profile = loadContext.eval(path); | ||
| loadWithExtensionCheck("application-" + profile + ".properties"); | ||
| loadWithExtensionCheck("application-" + profile + ".yaml"); | ||
| loadWithExtensionCheck("application-" + profile + ".yml"); |
There was a problem hiding this comment.
I'll merge this in but I think I'm noticing something subtle about loadWithExtensionCheck() ... which is that it will not load the FILE if the RESOURCE is found.
So I'm pondering:
- For this case we might want to try and load RESOURCE and FILE (regardless if the RESOURCE is found)
- Ordering wise we might want to load all the RESOURCE for all the profiles first, and then load all the FILE for all the profiles after (ordering here in terms of file properties overriding resource properties).
So I'm pondering those 2 subtle things. I'll merge this into master now though, get a new coffee and ponder those 2 things ...
There was a problem hiding this comment.
typically, my property files are only in src/main/resources so I'm not bothered
There was a problem hiding this comment.
I thought that was a feature tbh
There was a problem hiding this comment.
Yeah, I get that. 99% of the time there will not be FILE & RESOURCE defined (but for that 1% case I think we need to be consistent. Config generally loads all the FILEs afterwards as those are the "overrides" to the RESOURCE "defaults".
There was a problem hiding this comment.
I thought that was a feature tbh
Yeah, might be a bug in my eyes :)
That is, when we have a properties/yaml as FILE (so externally supplied) in theory it's put there to override RESOURCE (application supplied defaults) properties.
So Config as I see it really should be loading any FILE, and loading it after RESOURCE properties have been loaded. So it might be a feature but right now I feel it might be more a subtle "historic bug". It might be ok because the use cases typically do not have both RESOURCE and FILE.
It is tempting to change that to try to load FILE regardless if there was a RESOURCE found and loaded. Pondering, Hmm ...
Config generally loads RESOURCE source first, and FILE source later. This allows the FILE source properties to override the RESOURCE source properties in a predictable manner.
#81 Adjust load ordering of profiles
This change ensures that for any additional profiles defined in loadMain() the RESOURCE is loaded. - Keeps a track of the profile resources loaded - Ensures for any additional profiles defined via loadMain() that those RESOURCE are also loaded Background: Config generally loads RESOURCE source first, and FILE source later. This allows the FILE source properties to override the RESOURCE source properties in a predictable manner.
…rces #81 Adjust load ordering of profiles (take2)
Now can set the profiles and load multiple files based on that.
it can be done in three ways
CONFIG_PROFILESenv variable-Dconfig.profilesto the command-lineconfig.profilesproperty in a config fileFixes #79