Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#81 Adjust load ordering of profiles (take2) #84

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

rbygrave
Copy link
Contributor

This change ensures that for any additional profiles defined in loadMain() the RESOURCE is loaded.

  • Keeps a track of the profile resources loaded
  • Ensures for any additional profiles defined via loadMain() that those RESOURCE are also loaded

Background:
Config generally loads RESOURCE source first, and FILE source later. This allows the FILE source properties to override the RESOURCE source properties in a predictable manner.

This change ensures that for any additional profiles defined in loadMain() the RESOURCE is loaded.

- Keeps a track of the profile resources loaded
- Ensures for any additional profiles defined via loadMain() that those RESOURCE are also loaded

Background:
Config generally loads RESOURCE source first, and FILE source later. This allows the FILE source properties to override the RESOURCE source properties in a predictable manner.
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings one way or the other

@rbygrave rbygrave merged commit 9c1c6d2 into master Jul 11, 2023
3 checks passed
@rbygrave rbygrave added this to the 3.5 milestone Jul 11, 2023
@rbygrave rbygrave self-assigned this Jul 11, 2023
@SentryMan SentryMan deleted the feature/81-profile-additional-resources branch October 7, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants