Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ModuleReader to be an instance with state #6

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Change ModuleReader to be an instance with state #6

merged 1 commit into from
Aug 28, 2023

Conversation

rbygrave
Copy link
Contributor

Refactor out readLine() method to ease unit testing

@rbygrave
Change ModuleReader to be an instance with state
c4de8f9 
Refactor out readLine() method to ease unit testing
SentryMan
SentryMan approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SentryMan SentryMan merged commit ddc0e2e into main Aug 28, 2023
4 checks passed
@SentryMan SentryMan deleted the feature/ModuleReader-use-instance branch August 28, 2023 15:08
@SentryMan SentryMan added this to the 1.1 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rbygrave @SentryMan