Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints for plio's, user's and org's settings #282

Merged
merged 27 commits into from
Feb 9, 2022

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented Dec 22, 2021

Fixes #281
Requires this to be merged

Summary

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@deepansh96 deepansh96 added the enhancement New feature or request label Dec 22, 2021
@deepansh96 deepansh96 added this to the v0.6 milestone Dec 22, 2021
@pep8speaks
Copy link

pep8speaks commented Dec 22, 2021

Hello @deepansh96! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:101: E501 line too long (138 > 100 characters)
Line 14:101: E501 line too long (139 > 100 characters)

Line 182:101: E501 line too long (110 > 100 characters)

Comment last updated at 2022-01-31 06:16:10 UTC

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #282 (bb5f274) into master (89e8032) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   97.57%   97.65%   +0.08%     
==========================================
  Files         150      151       +1     
  Lines        3007     3119     +112     
==========================================
+ Hits         2934     3046     +112     
  Misses         73       73              
Impacted Files Coverage Δ
organizations/serializers.py 100.00% <ø> (ø)
...ganizations/migrations/0004_organization_config.py 100.00% <100.00%> (ø)
organizations/models.py 92.68% <100.00%> (+0.18%) ⬆️
organizations/permissions.py 100.00% <100.00%> (ø)
organizations/tests.py 100.00% <100.00%> (ø)
organizations/views.py 100.00% <100.00%> (ø)
plio/tests.py 100.00% <100.00%> (ø)
plio/views.py 99.04% <100.00%> (+0.02%) ⬆️
users/serializers.py 97.50% <100.00%> (+0.27%) ⬆️
users/tests.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e8032...bb5f274. Read the comment docs.

plio/views.py Outdated Show resolved Hide resolved
@deepansh96 deepansh96 temporarily deployed to Staging January 7, 2022 11:10 Inactive
@deepansh96 deepansh96 changed the title NEW: endpoints for plio's settings and user's settings NEW: endpoints for plio's, user's and org's settings Jan 15, 2022
@deepansh96 deepansh96 temporarily deployed to Staging January 15, 2022 09:46 Inactive
organizations/views.py Outdated Show resolved Hide resolved
users/views.py Outdated Show resolved Hide resolved
organizations/tests.py Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
organizations/views.py Outdated Show resolved Hide resolved
organizations/views.py Outdated Show resolved Hide resolved
organizations/views.py Outdated Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
@deepansh96 deepansh96 temporarily deployed to Staging February 9, 2022 08:26 Inactive
@dalmia dalmia merged commit c5f9682 into master Feb 9, 2022
@dalmia dalmia deleted the feature/settings-menu-skip-configurable branch February 9, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to update/create the settings key inside the config (JSONField) of Plio, User and Organizations models
3 participants