Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/settings menu skip configurable #570

Merged
merged 82 commits into from
Feb 9, 2022

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented Dec 22, 2021

Fixes #569
Requires this to be merged

Summary

Summary here

Test Plan

  • Test Responsiveness
    • Laptop (1200px)
    • Tablet (760px)
    • Phone (320px)
  • Cross-Browser Testing
    • Chrome
    • Firefox
    • Safari (use BrowserStack)
  • Local Language Support
  • Hygiene and Housekeeping
    • Self-review
    • Comments have been added appropriately
    • Check for bundle size here if adding a package
    • Added relevant details like Labels/Projects/Milestones etc.
  • Testing
    • Wrote tests
    • Tested locally
    • Tested on staging
    • Tested on an actual physical phone
    • Tested on production
  • Lighthouse Checks
    • Images have alt attributes
    • Any <img> tags have width and height specified
    • Any target="_blank" links have rel="noopener"
    • Only SVGs are used as images. If PNGs are used, their size has been optimised.
    • Any SVGs without text have their aria-label attributes set

@cypress
Copy link

cypress bot commented Dec 22, 2021



Test summary

7 3 0 0


Run details

Project Plio
Status Failed
Commit d92a294
Started Jan 25, 2022 11:22 AM
Ended Jan 25, 2022 11:24 AM
Duration 01:08 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

home/home.spec.js Failed
1 Home > the plio list is loaded
login/login-hindi.spec.js Failed
1 Login > logs into the system using google auth
login/login.spec.js Failed
1 Login > logs into the system using google auth

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #570 (85193c0) into master (7ecea7f) will decrease coverage by 0.93%.
The diff coverage is 83.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   85.06%   84.13%   -0.94%     
==========================================
  Files          65       69       +4     
  Lines        4018     4356     +338     
  Branches      682      765      +83     
==========================================
+ Hits         3418     3665     +247     
- Misses        574      666      +92     
+ Partials       26       25       -1     
Impacted Files Coverage Δ
src/components/Editor/ItemEditor.vue 93.62% <ø> (ø)
src/components/Items/Question/Header.vue 93.02% <ø> (ø)
src/components/UI/Text/TimeInput.vue 100.00% <ø> (ø)
src/pages/Dashboard.vue 94.94% <ø> (ø)
src/pages/Error.vue 0.00% <0.00%> (ø)
src/pages/Player.vue 61.53% <ø> (ø)
src/services/API/RootClient.js 10.00% <ø> (ø)
src/services/Functional/User.js 0.00% <ø> (ø)
src/services/Functional/Utilities/Generic.js 100.00% <ø> (ø)
src/router/index.js 65.00% <50.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecea7f...85193c0. Read the comment docs.

src/store/modules/auth.js Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/pages/Editor.vue Outdated Show resolved Hide resolved
@dalmia dalmia temporarily deployed to Staging February 9, 2022 07:55 Inactive
@dalmia dalmia merged commit 6f9015b into master Feb 9, 2022
@dalmia dalmia deleted the feature/settings-menu-skip-configurable branch February 9, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a settings menu + Add a setting to make Skip Question button configurable
2 participants