Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ca_file settings for all backends #447

Merged
merged 17 commits into from
Mar 23, 2022
Merged

Add ca_file settings for all backends #447

merged 17 commits into from
Mar 23, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Feb 25, 2022 •
edited
Loading

Option for adding the given PEM encoded ca-certificate to the existing system certificate pool for all outgoing connections.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

filex
filex requested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@filex filex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional test was successful.

we should add logging of the used file at startup.

@malud malud requested a review from filex March 7, 2022 07:44
@malud malud marked this pull request as ready for review March 10, 2022 16:24
johakoch
johakoch reviewed Mar 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@johakoch
Copy link
Collaborator

we should add logging of the used file at startup.

logging is now implemented:

level=info msg="configured with ca-certificate: /tmp/ca.cert2476670474"

Marcel Ludwig and others added 11 commits March 21, 2022 12:45
Add ca_file settings for all backends
4e27b8e
fixup args
8c29a73
fix: missing request.proto for upstream logs (#421)
8ecd8c4 
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
@johakoch
Fix hcl for loop (#426)
159aaf1 
* Test with `for` loops

* Fix happy cases with `for` loops

* changelog entry
@johakoch
Fix conditional predicate (#429)
14c67dc 
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean

* fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error

* changelog entry
Add ca-file start log and test
8ad9f86
rebase fixup
0ddc105
Refine ca-cert file error-handling
e9ff90d
@johakoch
Update CHANGELOG.md
32f81a2 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Add comment how we read the cert-file
51a62ca
increase expiresIn due to slow test worker
6cc513f
johakoch
johakoch requested changes Mar 23, 2022
View reviewed changes
server/tls.go Outdated Show resolved Hide resolved
Marcel Ludwig and others added 2 commits March 23, 2022 12:29
disable expired test for now
8d17cc5
@johakoch
Update server/tls.go
58b2461 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
@johakoch johakoch merged commit 1f4e097 into master Mar 23, 2022
@johakoch johakoch deleted the feature/ca-file branch March 23, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

@filex filex Awaiting requested review from filex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malud @johakoch @filex