Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing request.proto for upstream logs #421

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Conversation

malud
Copy link
Collaborator

@malud malud commented Jan 10, 2022

use final outreq for url proto log


Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud requested a review from johakoch January 10, 2022 14:55
@malud malud marked this pull request as draft January 10, 2022 15:55
johakoch
johakoch previously approved these changes Jan 10, 2022
@johakoch johakoch merged commit 8898009 into master Jan 12, 2022
@johakoch johakoch deleted the upstream-proto branch January 12, 2022 08:23
malud pushed a commit that referenced this pull request Feb 22, 2022
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
malud pushed a commit that referenced this pull request Mar 7, 2022
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
malud pushed a commit that referenced this pull request Mar 7, 2022
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
malud pushed a commit that referenced this pull request Mar 18, 2022
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
malud pushed a commit that referenced this pull request Mar 21, 2022
* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests
johakoch added a commit that referenced this pull request Mar 23, 2022
* Add ca_file settings for all backends

* fixup args

* fix: missing `request.proto` for upstream logs (#421)

* use final outreq for url proto log

* fixup obsolete check

* changelog

* Add test

Fix hook entries call for other tests

* Fix hcl `for` loop (#426)

* Test with `for` loops

* Fix happy cases with `for` loops

* changelog entry

* Fix conditional predicate (#429)

* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean

* fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error

* changelog entry

* Add ca-file start log and test

* rebase fixup

* Refine ca-cert file error-handling

* Update CHANGELOG.md

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>

* Add comment how we read the cert-file

* increase expiresIn due to slow test worker

* Test fixup: create buffer body with content only

* Fresh conns for test client

* fix typo

* disable expired test for now

* Update server/tls.go

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants