Fix conditional predicate #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2022 15:33
…l here, because null is not boolean
…original conditional expression to trigger and pass evaluation error
johakoch
force-pushed
the
fix-conditional-predicate
branch
from
b12c3d8
to
d53a7b4
Compare
alex-schneider
approved these changes
Feb 1, 2022
malud
pushed a commit
that referenced
this pull request
Feb 22, 2022
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry
malud
pushed a commit
that referenced
this pull request
Mar 7, 2022
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry
malud
pushed a commit
that referenced
this pull request
Mar 7, 2022
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry
malud
pushed a commit
that referenced
this pull request
Mar 18, 2022
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry
malud
pushed a commit
that referenced
this pull request
Mar 21, 2022
* test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry
johakoch
added a commit
that referenced
this pull request
Mar 23, 2022
* Add ca_file settings for all backends * fixup args * fix: missing `request.proto` for upstream logs (#421) * use final outreq for url proto log * fixup obsolete check * changelog * Add test Fix hook entries call for other tests * Fix hcl `for` loop (#426) * Test with `for` loops * Fix happy cases with `for` loops * changelog entry * Fix conditional predicate (#429) * test for conditionals with non-boolean predicates; moved test for null here, because null is not boolean * fix: check predicate value type; if predicate is not boolean, return original conditional expression to trigger and pass evaluation error * changelog entry * Add ca-file start log and test * rebase fixup * Refine ca-cert file error-handling * Update CHANGELOG.md Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com> * Add comment how we read the cert-file * increase expiresIn due to slow test worker * Test fixup: create buffer body with content only * Fresh conns for test client * fix typo * disable expired test for now * Update server/tls.go Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com> Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix handling of HCL conditionals: check predicate for evaluating to bool
Reviewer checklist