Skip to content

Commit

Permalink
fix: fix failing github actions
Browse files Browse the repository at this point in the history
Co-authored-by: ferferga <ferferga@hotmail.com>

Due to a regression in npm 9.3.0 (upgraded by Node.JS 18 LTS at 18.14.0,
see https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-02-version-18140-hydrogen-lts-bethgriggs-prepared-by-juanarbol),
the `npm get config` command stopped working in workspaces. This made
our actions using actions/setup-node to fail.

Issues were opened in the relevant repositories since january
and february (check npm/cli#6099 and actions/setup-node#712)
but it looks like getting this fixed upstream it's going to take a long time.
We have been waiting for a really long time
for other fixes in npm, so I don't expect this situation will be solved really soon

We need a working CI before the Vue 3 merge, so applying this commit will
solve the issue in the meantime. In the future, it might be interesting
to revert this commit.

Also format the Gitrhub Actions workflows using the official VSCode GitHub extension
  • Loading branch information
aweebs authored and ferferga committed Mar 28, 2023
1 parent 3b269f0 commit 00ae112
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 21 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/automation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
branches:
- master
paths-ignore:
- '**/*.md'
- "**/*.md"
pull_request_target:

jobs:
Expand Down Expand Up @@ -63,10 +63,10 @@ jobs:
if: ${{ github.event_name == 'pull_request_target' }}
continue-on-error: true
with:
repo-token: '${{ secrets.JF_BOT_TOKEN }}'
repo-token: "${{ secrets.JF_BOT_TOKEN }}"

- name: Check all PRs for merge conflicts ⛔
uses: eps1lon/actions-label-merge-conflict@v2.1.0
with:
dirtyLabel: 'merge conflict'
dirtyLabel: "merge conflict"
repoToken: ${{ secrets.JF_BOT_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/codeQL.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- master
pull_request:
paths-ignore:
- '**/*.md'
- "**/*.md"
workflow_call:

jobs:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
uses: actions/setup-node@v3.5.1
with:
node-version: 18
cache: "npm"
check-latest: true

- name: Install dependencies 📦
Expand All @@ -56,7 +55,6 @@ jobs:
uses: actions/setup-node@v3.5.1
with:
node-version: 18
cache: "npm"
check-latest: true

- name: Install dependencies 📦
Expand Down Expand Up @@ -139,7 +137,6 @@ jobs:
uses: actions/setup-node@v3.5.1
with:
node-version: 18
cache: "npm"
check-latest: true

- name: Install dependencies 📦
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/job_messages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ on:
value: ${{ jobs.msg.outputs.msg }}
marker:
description: Hidden marker to detect PR comments composed by the bot
value: 'CFPages-deployment'
value: "CFPages-deployment"

jobs:
msg:
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ jobs:
fail-fast: false
matrix:
platform:
- 'macos-latest'
- 'ubuntu-latest'
- 'windows-latest'
- "macos-latest"
- "ubuntu-latest"
- "windows-latest"

runs-on: ${{ matrix.platform }}
steps:
Expand All @@ -85,7 +85,6 @@ jobs:
uses: actions/setup-node@v3.5.1
with:
node-version: 18
cache: 'npm'
check-latest: true

- name: Install dependencies 📦
Expand All @@ -98,10 +97,10 @@ jobs:
sudo apt-get install -y webkit2gtk-4.0
- name: Generate Tauri icons 🖌️
run: 'npm run tauri:icon -w tauri'
run: "npm run tauri:icon -w tauri"

- name: Build Tauri 🛠️
run: 'npm run tauri:build -w tauri'
run: "npm run tauri:build -w tauri"

- name: Upload artifact (Linux) ⬆️🐧
uses: actions/upload-artifact@v3.1.1
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/unstable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
branches:
- master
paths-ignore:
- '**/*.md'
- "**/*.md"

jobs:
docker:
Expand Down Expand Up @@ -78,9 +78,9 @@ jobs:
fail-fast: false
matrix:
platform:
- 'macos-latest'
- 'ubuntu-latest'
- 'windows-latest'
- "macos-latest"
- "ubuntu-latest"
- "windows-latest"

runs-on: ${{ matrix.platform }}
steps:
Expand All @@ -91,7 +91,6 @@ jobs:
uses: actions/setup-node@v3.5.1
with:
node-version: 18
cache: 'npm'
check-latest: true

- name: Install dependencies 📦
Expand All @@ -104,10 +103,10 @@ jobs:
sudo apt-get install -y webkit2gtk-4.0
- name: Generate Tauri icons 🖌️
run: 'npm run tauri:icon -w tauri'
run: "npm run tauri:icon -w tauri"

- name: Build Tauri 🛠️
run: 'npm run tauri:build -w tauri'
run: "npm run tauri:build -w tauri"

- name: Upload artifact (Linux) ⬆️🐧
uses: actions/upload-artifact@v3.1.1
Expand Down

0 comments on commit 00ae112

Please sign in to comment.