-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use sub:username identity claim by default when persisting behind a feature flag #10196
feat: use sub:username identity claim by default when persisting behind a feature flag #10196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but overall LGTM
packages/graphql-transformers-e2e-tests/src/__tests__/MultiAuthV2Transformer.e2e.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-graphql-auth-transformer/src/graphql-auth-transformer.ts
Outdated
Show resolved
Hide resolved
.eslint-dictionary.json
Outdated
"iam", | ||
"indicies", | ||
"integtestFn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was reordered, not added, so I'll leave it and we can remove non words in another PR.
6423874
to
49c2b3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some snapshots need to be updated, otherwise seems good
49c2b3b
to
c287be9
Compare
Codecov Report
@@ Coverage Diff @@
## master #10196 +/- ##
==========================================
+ Coverage 54.25% 54.43% +0.18%
==========================================
Files 849 854 +5
Lines 46939 47026 +87
Branches 10004 10027 +23
==========================================
+ Hits 25467 25599 +132
+ Misses 19456 19413 -43
+ Partials 2016 2014 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@marcvberg this has been rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a48fabe
to
f7ce05a
Compare
1c213c4
to
928c00e
Compare
d724f00
to
5c16224
Compare
e6aca26
to
9f3ef5f
Compare
5c16224
to
ca1912e
Compare
32b5209
to
4c5dd5f
Compare
When #10222 is merged, these tests will pass (they are due to mismatched snapshots) |
2de3c91
to
d46056b
Compare
d46056b
to
d88830f
Compare
Description of changes
This pull requests does the following:
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.