test: e2e tests to check that libraries can query new identity claim #10198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpc
approved these changes
Apr 13, 2022
jhockett
approved these changes
Apr 13, 2022
danielleadams
requested review from
marcvberg,
phani-srikar,
sundersc and
alharris-at
as code owners
Codecov Report
@@ Coverage Diff @@
## master #10198 +/- ##
=======================================
Coverage 54.27% 54.27%
=======================================
Files 849 849
Lines 46933 46933
Branches 10004 10004
=======================================
Hits 25471 25471
Misses 19445 19445
Partials 2017 2017 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
danielleadams
added a commit
to danielleadams/amplify-cli
that referenced
this pull request
Apr 21, 2022
danielleadams
added a commit
to danielleadams/amplify-cli
that referenced
this pull request
Apr 21, 2022
danielleadams
added a commit
to danielleadams/amplify-cli
that referenced
this pull request
Apr 21, 2022
danielleadams
force-pushed
the
ic-changes-e2e-tests
branch
from
5496121 to
1c64dea
Compare
danielleadams
added a commit
that referenced
this pull request
Apr 22, 2022
danielleadams
force-pushed
the
ic-changes-e2e-tests
branch
from
dbd4e1e to
c477658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Creates e2e tests to test for the new identity claim and ensure each library can still query for owner.
Description of how you validated changes
Ran these tests with the changes from #10196, #10189, & more to be added.
There will be a fast follow to deal with linting errors in these test files.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.