fix(graphql-transformer-common): improve generated graphql pluralization

[johnpc]

Description of changes

This commit adds the pluralize npm library instead of blindly appending an "s" to acheive
pluralization. For example, a model named "Match" should pluralize to "Matches", but before this
commit Amplify would pluralize it to "Matchs"

Issue #, if available

This PR fixes #4224

It's worth noting that another pull request (#7030) was created to solve the same issue. However, multiple comments were left with suggestions to fix, and the author of the PR hasn't pushed out an update for a few weeks.

Additionally, that PR as written only solves the problem for models that end in an "s" or are otherwise already plural. It did not solve the issue in my case (the "Match" model being pluralized to "Matchs").

It's worth noting that pr #7030 also updated .circleci/config.yml. I couldn't figure out why that change was necessary. If it is, please let me know and I'll add it here.

Description of how you validated changes

• Updated unit test snapshot
• Used amplify-devcli with previously incorrectly pluralized model names (Tomatoes and Match)

Checklist

• PR description included
• yarn test passes
• Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[cjihrig]

Thanks for the PR @johnpc. As mentioned in #7030 and #4224, this work needs to be behind a feature flag before we can consider merging it.

[johnpc]

Thanks for the feedback! I updated the pull request to put this change behind a feature flag. Unfortunately, since the plurality util is widely used, I had to add mocking across several test files. Please advise if there is a better way to accomplish it.

[SwaySway]

@johnpc You can add the FeatureFlag when creating an instance of GraphQL Transform. Example below:

amplify-cli/packages/graphql-transformers-e2e-tests/src/__tests__/KeyTransformerLocal.e2e.test.ts

Lines 329 to 337 in cda63df

	const transformer = new GraphQLTransform({
	transformers: [new DynamoDBModelTransformer(), new KeyTransformer()],
	featureFlags: {
	getBoolean: (featureName: string, defaultValue: boolean) => {
	if (featureName === 'secondaryKeyAsGSI') return false;
	return defaultValue || false;
	},
	} as unknown as FeatureFlagProvider
	});

[johnpc]

does that apply to all the test files where I added the mock? Some of these files don't explicitly instantiate a GraphQLTransform instance

[codecov-commenter]

Codecov Report

Merging #7258 (0843e8d) into master (3dbb3bf) will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #7258      +/-   ##
==========================================
+ Coverage   52.72%   52.74%   +0.02%     
==========================================
  Files         513      513              
  Lines       25914    25917       +3     
  Branches     5058     5059       +1     
==========================================
+ Hits        13662    13669       +7     
+ Misses      11286    11282       -4     
  Partials      966      966              

Impacted Files	Coverage Δ
...amplify-cli-core/src/feature-flags/featureFlags.ts	83.10% <ø> (ø)
...rc/graphql-transformer/transform-graphql-schema.ts	15.05% <ø> (ø)
...ages/graphql-dynamodb-transformer/src/resources.ts	71.42% <0.00%> (ø)
...arch-transformer/src/SearchableModelTransformer.ts	95.23% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts	92.59% <0.00%> (ø)
...-transformer/src/graphql-searchable-transformer.ts	97.02% <100.00%> (+0.02%)	⬆️
...aphql-auth-transformer/src/ModelAuthTransformer.ts	89.10% <100.00%> (+0.43%)	⬆️
...uth-transformer/src/ModelDirectiveConfiguration.ts	74.73% <100.00%> (+0.54%)	⬆️
...namodb-transformer/src/DynamoDBModelTransformer.ts	92.52% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb3bf...0843e8d. Read the comment docs.

[edwardfoyle]

Reverting this PR as it appears to be causing a couple of e2e tests to fail: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/1120/workflows/28f71966-47f4-476a-98da-a368a4bd69c3

[github-actions]

👋 Hi, this pull request was referenced in the v5.0.2 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.2.

[github-actions]

👋 Hi, this pull request was referenced in the v5.1.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.1.0.

[lawmicha]

If we set the flag to true for new projects, they immediately won't work with the existing iOS library. This is a breaking change, right?
before:

• type Wish generates listWishs
• type Wishes generates listWishess

after:

• type Wish generates listWishes
• type Wishes generates listWishes

How do new projects work with existing iOS library? (investigating in #8350) Is it because iOS library has logic coupled to how the name is generated, and shoudn't have in the first place? Should we have feature flags for the libraries as well?