Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct featuer typo in gql transformer v2 #7584

Merged
merged 1 commit into from
Jun 24, 2021
Merged

fix: correct featuer typo in gql transformer v2 #7584

merged 1 commit into from
Jun 24, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 23, 2021

Description of changes

This commit fixes a typo in the transformer API.

This was fixed as part of a larger change in #7258, but reverted in #7578. We should fix this typo since it is part of the public API.

Issue #, if available

Description of how you validated changes

yarn test

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit fixes a typo in the transformer API.
@cjihrig cjihrig requested a review from a team as a code owner June 23, 2021 00:36
@codecov-commenter
Copy link

Codecov Report

Merging #7584 (6c68b7f) into master (e3e51f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7584   +/-   ##
=======================================
  Coverage   52.63%   52.63%           
=======================================
  Files         525      525           
  Lines       26497    26497           
  Branches     5136     5136           
=======================================
  Hits        13946    13946           
  Misses      11579    11579           
  Partials      972      972           
Impacted Files Coverage Δ
...rc/graphql-transformer/transform-graphql-schema.ts 15.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e51f5...6c68b7f. Read the comment docs.

@cjihrig cjihrig mentioned this pull request Jun 23, 2021
3 tasks
Copy link
Contributor

@johnpc johnpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@edwardfoyle edwardfoyle merged commit 81659ee into aws-amplify:master Jun 24, 2021
@cjihrig cjihrig deleted the typo branch June 25, 2021 15:17
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.1.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.1.0.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 30, 2021
cjihrig added a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants