-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign in with Apple - add and update auth #7265
Sign in with Apple - add and update auth #7265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7265 +/- ##
==========================================
- Coverage 52.32% 52.24% -0.08%
==========================================
Files 499 499
Lines 25546 25585 +39
Branches 5006 5014 +8
==========================================
Hits 13367 13367
- Misses 11230 11261 +31
- Partials 949 957 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but LGTM
...fy-category-auth/src/provider-utils/awscloudformation/service-walkthroughs/auth-questions.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm - can you also add some tests to verify the add auth with siwa and headless pull with siwa works as expected?
This pull request introduces 1 alert when merging d522c14 into 5c918be - view on LGTM.com new alerts:
|
Co-authored-by: Edward Foyle <foyleef@amazon.com>
This pull request introduces 1 alert when merging bbb18ad into 5c918be - view on LGTM.com new alerts:
|
…/letsbelopez/amplify-cli into category-auth/sign-in-with-apple
This pull request introduces 1 alert when merging 08eeba9 into d28dd1c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces 1 alert when merging 68fe947 into d28dd1c - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 2a58958 into d28dd1c - view on LGTM.com new alerts:
|
packages/amplify-category-auth/src/provider-utils/awscloudformation/index.js
Show resolved
Hide resolved
👋 Hi, this pull request was referenced in the v4.51.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0. |
This reverts commit 9f5e659.
* Revert "feat: Support for Apple Sign In (#7265)"
* Revert "feat: Support for Apple Sign In (aws-amplify#7265)"
Description of changes
Updated the --headless add and update auth flow to take Sign in with Apple in the headless payload and update the Cognito user pool.
Issue #, if available
Description of how you validated changes
I use a test web project and passed in the new SIWA headless payloads with the add and update commands:
cat MyAuthTemplate.addauth.json | jq -c '.' | amplify add auth --headless
I verified the changes in Cognito console.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.