Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support AWS::URLSuffix CFN pseudo-param in mock #7416

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix: support AWS::URLSuffix CFN pseudo-param in mock #7416

merged 1 commit into from
Jun 21, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 28, 2021

Description of changes

This commit adds mock support for the CFN pseudo-parameter AWS::URLSuffix, which is used by the GraphQL transformer v2.

Issue #, if available

Description of how you validated changes

Manual and unit testing

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjihrig cjihrig requested a review from a team as a code owner May 28, 2021 04:48
@codecov-commenter
Copy link

Codecov Report

Merging #7416 (c45b58f) into master (be441c9) will increase coverage by 0.00%.
The diff coverage is 64.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7416   +/-   ##
=======================================
  Coverage   52.74%   52.75%           
=======================================
  Files         514      514           
  Lines       25919    25916    -3     
  Branches     5059     5056    -3     
=======================================
  Hits        13672    13672           
+ Misses      11280    11277    -3     
  Partials      967      967           
Impacted Files Coverage Δ
...l-mock/src/CFNParser/appsync-resource-processor.ts 0.00% <ø> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <ø> (ø)
...-util-mock/src/utils/lambda/populate-cfn-params.ts 0.00% <ø> (ø)
...ider-awscloudformation/src/display-helpful-urls.js 16.90% <33.33%> (+0.35%) ⬆️
...wscloudformation/utils/auth-sms-workflow-helper.ts 45.45% <80.00%> (+21.64%) ⬆️
...r-utils/awscloudformation/utils/message-printer.ts 50.00% <100.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c115f...c45b58f. Read the comment docs.

Copy link
Contributor

@sundersc sundersc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardfoyle edwardfoyle merged commit ef5a507 into aws-amplify:master Jun 21, 2021
@cjihrig cjihrig deleted the pseudo branch June 22, 2021 01:54
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.2 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.2.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 24, 2021
cjihrig added a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants