Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support AWS::URLSuffix CFN pseudo-param in mock #7416

Merged
merged 1 commit into from
Jun 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const CFN_DEFAULT_PARAMS = {
'AWS::AccountId': '12345678910',
'AWS::StackId': 'fake-stackId',
'AWS::StackName': 'local-testing',
'AWS::URLSuffix': 'amazonaws.com',
};

const RESOLVER_TEMPLATE_LOCATION_PREFIX = 's3://${S3DeploymentBucket}/${S3DeploymentRootKey}/';
Expand Down
1 change: 1 addition & 0 deletions packages/amplify-util-mock/src/CFNParser/stack/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const CFN_PSEUDO_PARAMS = {
'AWS::AccountId': '12345678910',
'AWS::StackId': 'fake-stackId',
'AWS::StackName': 'local-testing',
'AWS::URLSuffix': 'amazonaws.com',
};

export function nestedStackHandler(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ describe('populate cfn params', () => {
'AWS::AccountId': '1234',
'AWS::StackId': 'arn:aws:cloudformation:us-test-1:1234:stack/my-test-stack',
'AWS::StackName': 'test-stack-name',
'AWS::URLSuffix': 'amazonaws.com',
});
});

Expand All @@ -93,6 +94,7 @@ describe('populate cfn params', () => {
'AWS::AccountId': '12345678910',
'AWS::StackId': 'fake-stack-id',
'AWS::StackName': 'local-testing',
'AWS::URLSuffix': 'amazonaws.com',
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const getCfnPseudoParams = (): Record<string, string> => {
'AWS::AccountId': accountId,
'AWS::StackId': stackId,
'AWS::StackName': stackName,
'AWS::URLSuffix': 'amazonaws.com',
};
};

Expand Down