Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add region eu-west-3 #8056

Closed
wants to merge 1 commit into from
Closed

Conversation

magrinj
Copy link

@magrinj magrinj commented Aug 27, 2021

Description of changes

Add eu-west-3 region.
Not sure of the changes, but it seems to work locally.

Issue #5832

Description of how you validated changes

Run cli binary locally to confirm it works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@magrinj magrinj requested a review from a team as a code owner August 27, 2021 21:26
@codecov-commenter
Copy link

Codecov Report

Merging #8056 (d1029ea) into master (7b5de7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8056   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files         657      657           
  Lines       37484    37484           
  Branches     7696     7696           
=======================================
  Hits        20295    20295           
  Misses      16349    16349           
  Partials      840      840           
Impacted Files Coverage Δ
...lify-provider-awscloudformation/src/aws-regions.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5de7b...d1029ea. Read the comment docs.

@siegerts siegerts added the first-time-contributor The contribution is the first for this user in the repo label Aug 27, 2021
@cjihrig
Copy link
Contributor

cjihrig commented Sep 13, 2021

Thanks for the PR. In general, we can't accept external contributions to enable new regions. However, eu-west-3 support landed recently in #8094, and should be available in the next release.

@cjihrig cjihrig closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor The contribution is the first for this user in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants