Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support five new regions in CLI #8094

Merged
merged 4 commits into from
Sep 10, 2021
Merged

feat: support five new regions in CLI #8094

merged 4 commits into from
Sep 10, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 3, 2021

Description of changes

This commit updates the CLI to support five new regions:

  • us-west-1
  • eu-west-3
  • eu-north-1
  • me-south-1
  • sa-east-1

Marking this as a draft because I'm still waiting on some information regarding me-south-1.

Issue #, if available

Description of how you validated changes

Manual testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #8094 (67654f6) into master (4ee9232) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8094   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files         663      663           
  Lines       37829    37829           
  Branches     7767     7767           
=======================================
  Hits        20589    20589           
  Misses      16400    16400           
  Partials      840      840           
Impacted Files Coverage Δ
...ble-transformer/src/cdk/create-layer-cfnMapping.ts 100.00% <ø> (ø)
...lify-provider-awscloudformation/src/aws-regions.js 100.00% <ø> (ø)
...vider-awscloudformation/src/utils/admin-helpers.ts 17.54% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee9232...67654f6. Read the comment docs.

cjihrig-aws and others added 3 commits September 7, 2021 18:26
This commit updates the CLI to support five new regions:

- us-west-1
- eu-west-3
- eu-north-1
- me-south-1
- sa-east-1
@cjihrig cjihrig marked this pull request as ready for review September 7, 2021 22:33
@cjihrig cjihrig requested a review from a team as a code owner September 7, 2021 22:33
Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, but LGTM

packages/amplify-e2e-core/src/configure/index.ts Outdated Show resolved Hide resolved
@jhockett jhockett merged commit 98e6c56 into aws-amplify:master Sep 10, 2021
@cjihrig cjihrig deleted the regions branch September 10, 2021 19:11
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.6.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.6.0.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Sep 14, 2021
marcvberg pushed a commit to marcvberg/amplify-cli that referenced this pull request Oct 13, 2021
* feat: support five new regions in CLI

This commit updates the CLI to support five new regions:

- us-west-1
- eu-west-3
- eu-north-1
- me-south-1
- sa-east-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
4 participants