Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventAttributes type #2581

Merged
merged 7 commits into from
Jan 22, 2019
Merged

Update EventAttributes type #2581

merged 7 commits into from
Jan 22, 2019

Conversation

elorzafe
Copy link
Contributor

Replacing PR #735 (inactive) Thanks @gnomishperson

Issue #, if available:
#734
Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Replacing #735 (inactive)
@elorzafe elorzafe requested a review from powerful23 January 19, 2019 00:40
@ghost ghost assigned elorzafe Jan 19, 2019
@ghost ghost added the review label Jan 19, 2019
Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@elorzafe
Copy link
Contributor Author

@powerful23 I fixed an issue with SessionTracker, can you take a look?

Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change made in #2180

packages/analytics/src/trackers/SessionTracker.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@elorzafe elorzafe merged commit 2309e6e into master Jan 22, 2019
@ghost ghost removed the review label Jan 22, 2019
@elorzafe elorzafe deleted the elorzafe-analytics-type-issue branch January 22, 2019 18:49
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants