Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed value type in EventAttribute interface #735

Closed
wants to merge 1 commit into from

Conversation

gnomishperson
Copy link

Changed type from any to string on the value in the EventAttribute interface for the Analtyics lib.

Should resolve issue #734

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #735 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #735   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          74       74           
  Lines        3530     3530           
  Branches      671      671           
=======================================
  Hits         3059     3059           
  Misses        454      454           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799b40c...927c450. Read the comment docs.

@mlabieniec mlabieniec requested a review from powerful23 April 26, 2018 23:13
Copy link
Contributor

@powerful23 powerful23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi this is good change but it should be in this line

@gnomishperson
Copy link
Author

Woops, hah, fixing.

Changed type from `any` to `string` on the value in the EventAttribute interface for the Analtyics lib.
@powerful23
Copy link
Contributor

@gnomishperson Hey sorry for the late response. Can you update it and resolve those conflicts? Or I can make this change in my next pr. Thanks!

elorzafe added a commit that referenced this pull request Jan 19, 2019
Replacing #735 (inactive)
@elorzafe
Copy link
Contributor

Thanks @gnomishperson I replaced this pr because is more simple create a new one than resolve the conflicts.

Thanks again!

@elorzafe elorzafe closed this Jan 19, 2019
@ghost ghost removed the review label Jan 19, 2019
elorzafe added a commit that referenced this pull request Jan 22, 2019
* Update EventAttributes type

Replacing #735 (inactive)

* Added comment and updated type to allow promises
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Analytics Related to analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants