-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed value type in EventAttribute interface #735
Conversation
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 74 74
Lines 3530 3530
Branches 671 671
=======================================
Hits 3059 3059
Misses 454 454
Partials 17 17 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi this is good change but it should be in this line
Woops, hah, fixing. |
Changed type from `any` to `string` on the value in the EventAttribute interface for the Analtyics lib.
@gnomishperson Hey sorry for the late response. Can you update it and resolve those conflicts? Or I can make this change in my next pr. Thanks! |
Thanks @gnomishperson I replaced this pr because is more simple create a new one than resolve the conflicts. Thanks again! |
* Update EventAttributes type Replacing #735 (inactive) * Added comment and updated type to allow promises
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Changed type from
any
tostring
on the value in the EventAttribute interface for the Analtyics lib.Should resolve issue #734
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.