Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3620): Error when building with AOT enabled when using Angular #4883

Merged
merged 5 commits into from
May 21, 2020

Conversation

jmhummel
Copy link
Contributor

Issue #, if available:
fixes(#3620)

Description of changes:
This will allow users to use the strict template check option for Angular AOT compilation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #4883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4883   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files         204      204           
  Lines       11973    11973           
  Branches     2254     2342   +88     
=======================================
  Hits         8831     8831           
+ Misses       2980     2960   -20     
- Partials      162      182   +20     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 49.64% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89e545...8f1a139. Read the comment docs.

@ericclemmons ericclemmons added this to the Angular 9 (Ivy) Support milestone Feb 11, 2020
@ericclemmons ericclemmons changed the title fixes(#3620) fixes(#3620): Error when building with AOT enabled when using Angular Mar 17, 2020
@ericclemmons ericclemmons changed the title fixes(#3620): Error when building with AOT enabled when using Angular fix(#3620): Error when building with AOT enabled when using Angular Mar 17, 2020
@isaacdre
Copy link

isaacdre commented Apr 2, 2020

My ts compiler called... it wants it's fullTemplateTypeCheck to flip back to true.

I tried to explain that patience is a virtue, but it replied, "Patience may be a virtue, but forgoing type checking before prod pushing is a mortal sin".

Having this patched would go a long way towards fixing my relationship with my compiler. It doesn't like turning a blind eye to my code.

@joeprisk
Copy link

I second this, can this be approved + merged?

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮 Thanks for contributing!

@sammartinez sammartinez merged commit 24eb104 into aws-amplify:master May 21, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants