-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#3620): Error when building with AOT enabled when using Angular #4883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4883 +/- ##
=======================================
Coverage 73.75% 73.75%
=======================================
Files 204 204
Lines 11973 11973
Branches 2254 2342 +88
=======================================
Hits 8831 8831
+ Misses 2980 2960 -20
- Partials 162 182 +20
Continue to review full report at Codecov.
|
My ts compiler called... it wants it's fullTemplateTypeCheck to flip back to true. I tried to explain that patience is a virtue, but it replied, "Patience may be a virtue, but forgoing type checking before prod pushing is a mortal sin". Having this patched would go a long way towards fixing my relationship with my compiler. It doesn't like turning a blind eye to my code. |
I second this, can this be approved + merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮 Thanks for contributing!
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
fixes(#3620)
Description of changes:
This will allow users to use the strict template check option for Angular AOT compilation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.