Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3620): Error when building with AOT enabled when using Angular #4883

Merged
merged 5 commits into from
May 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class AuthenticatorComponentCore implements OnInit {
_signUpConfig: any = {};
_usernameAttributes: string = 'username';

constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
this.subscribe();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const template = `
template,
})
export class AuthenticatorIonicComponent extends AuthenticatorComponentCore {
constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ export class ConfirmSignInComponentCore implements OnInit {
errorMessage: string;
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('ConfiSignInComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ export class ConfirmSignInComponentIonic extends ConfirmSignInComponentCore {
code: string;
errorMessage: string;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,7 @@ export class ConfirmSignUpComponentCore implements OnInit {
errorMessage: string;
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('ConfirmSignUpComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@ const template = `
template,
})
export class ConfirmSignUpComponentIonic extends ConfirmSignUpComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,7 @@ export class ForgotPasswordComponentCore implements OnInit {
country_code: string = '1';
email: string;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('ForgotPasswordComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,7 @@ const template = `
template,
})
export class ForgotPasswordComponentIonic extends ForgotPasswordComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ export class GreetingComponentCore implements OnInit {
_usernameAttributes: string = 'username';
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('GreetingComponent');
this.subscribe();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ const template = `
template,
})
export class GreetingComponentIonic extends GreetingComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ export class RequireNewPasswordComponentCore implements OnInit {
errorMessage: string;
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('RequireNewPasswordComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ const template = `
template,
})
export class RequireNewPasswordComponentIonic extends RequireNewPasswordComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,7 @@ export class SignInComponentCore implements OnInit {
signInUsername = '';
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('SignInComponent');
this.onUsernameFieldChanged = this.onUsernameFieldChanged.bind(this);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,7 @@ const template = `
template,
})
export class SignInComponentIonic extends SignInComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ export class SignUpComponentCore implements OnInit {
defaultCountryCode: string;
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('SignUpComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ const template = `
template,
})
export class SignUpComponentIonic extends SignUpComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ export class UsernameFieldComponentCore implements OnInit {
_placeholder: string = '';
username: string;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.onPhoneFieldChanged = this.onPhoneFieldChanged.bind(this);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ const template = `
template,
})
export class UsernameFieldComponentIonic extends UsernameFieldComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class ChatbotComponentCore implements OnInit {

constructor(
ref: ChangeDetectorRef,
@Inject(AmplifyService) protected amplifyService: AmplifyService
@Inject(AmplifyService) public amplifyService: AmplifyService
) {
this.ref = ref;
this.continueConversation = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class ChatbotComponentIonic extends ChatbotComponentCore {
constructor(
ref: ChangeDetectorRef,
@Inject(AmplifyService)
protected amplifyService: AmplifyService
public amplifyService: AmplifyService
) {
super(ref, amplifyService);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ export class PhotoPickerComponentCore implements OnInit {
errorMessage: string;
protected logger: any;

constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('PhotoPickerComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ const template = `
template,
})
export class PhotoPickerIonicComponent extends PhotoPickerComponentCore {
constructor(
@Inject(AmplifyService) protected amplifyService: AmplifyService
) {
constructor(@Inject(AmplifyService) public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class S3AlbumComponentCore implements OnInit {
@Output()
selected: EventEmitter<string> = new EventEmitter<string>();

constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('S3AlbumComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const template = `
template,
})
export class S3AlbumComponentIonic extends S3AlbumComponentCore {
constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class S3ImageComponentCore implements OnInit {
@Output()
selected: EventEmitter<string> = new EventEmitter<string>();

constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
this.logger = this.amplifyService.logger('S3ImageComponent');
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const template = `
template,
})
export class S3ImageComponentIonic extends S3ImageComponentCore {
constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
super(amplifyService);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class SumerianSceneComponentCore implements OnInit, OnDestroy {
this.sceneName = data.sceneName;
}

constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
this.amplifyUI = AmplifyUI;
this.logger = this.amplifyService.logger('SumerianSceneComponentCore');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const template = `
export class SumerianSceneComponentIonic extends SumerianSceneComponentCore {
amplifyUI: any;

constructor(protected amplifyService: AmplifyService) {
constructor(public amplifyService: AmplifyService) {
super(amplifyService);
}
}