Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API to accept key-value pairs which are appended to the connection username #765

Merged
merged 16 commits into from
Mar 13, 2019

Conversation

desokroshan
Copy link
Contributor

These values can be used for keeping track of usage metrics.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@desokroshan desokroshan requested a review from scb01 March 5, 2019 00:43
@desokroshan desokroshan marked this pull request as ready for review March 7, 2019 17:56
@frankmuellr frankmuellr added iot Issues with the AWS Android SDK for Internet of Things (IoT) Pull Request labels Mar 7, 2019
scb01
scb01 previously approved these changes Mar 13, 2019
Copy link
Contributor

@scb01 scb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the understanding that you will remove the code duplication referred to in the review comment.

@desokroshan desokroshan changed the base branch from master to develop March 13, 2019 22:43
@desokroshan desokroshan merged commit 90d727f into develop Mar 13, 2019
@desokroshan desokroshan deleted the AFR branch March 13, 2019 23:26
mutablealligator pushed a commit that referenced this pull request Mar 14, 2019
* Secure information stored in SharedPreferences

* Lower aws-android-sdk-core-test compile and target sdk version to 27

* Add a symlink to android-23.jar for core

* Add a gradle task that creates a symlink to android-23.jar for AWS Core

* Fix the gradle task that creates symbolic link to android-23.jar

* Change config.yml to setup android-23

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Fix pom.xml

* Improve exception handling in AWSKeyValueStore

* [2.12.3] Bump the patch version of 2.12.z

* Update 2.12.3 CHANGELOG

* Add the missing bucket prefixes to CleanupBucketIntegrationTests

* Fix a bug where migrating expirationDate in CognitoCachingCredentialsProvider crashes

* [2.12.4] Update changelog and bump version

* Annotate code specific to API Level 23 and above in AWSKeyValueStore

* Added API to accept key-value pairs which are appended to the connection username (#765)

The connection username is used as user metadata by the service for the purpose of metrics calculation.

* build android sdk with android-10 (#782)

* Add sign out options

* [MobileClient] Cleanup javadocs and remove unnecessary try..catch blocks

* [MobileClient] Add developer authenticated identities to federatedSignIn fixes #577

* [MobileClient] Add test for developer authenticated idenities federatedSignIn

* [MobileClient] Persist identity id for developer authenticated identities

* [MobileClient] Add AWSMobileClient as client usage tracker in user agent

* [MobileClient] Add device operations; Add error message to ReturningRunnable

* [MobileClient] Add global sign-out functionality

* [MobileClient] Add custom role arn to settings in federated sign-in persistence

* [MobileClient] Add forgot password test; Fix sign out globally test

* [MobileClient] [Userpools] [CognitoAuth] Add HostedUI and OAuth 2.0 code grant flow support

[MobileClient]
Add HostedUI and OAuth 2.0 code grant flow support

[Userpools]
Fix threading issues reported in issue #722

[CognitoAuth]
Added methods to reset AuthHandler and get session without launching UI
Fix erroneous user cancelled when redirecting back to app fixes #328

* [MobileClient] Fix multiple adds of SignInProvider to provider list fixes #766

* [MobileClient] Fix git merge issues

* [MobileClient] Fix integration tests for new configuration

* [CognitoAuth] Fix NPE when ASF feature turned off

* [MobileClient] Finalize APIs before release, add persistence flag to OAuth 2.0 and HostedUI features

* [AuthSDKs] Update maven repositories in pom to maven.google.com

* [Core] Fix NPE when setting persistence in AWSKeyValueStore after initialization

* [MobileClient] Ignore manual tests in automation

* [MobileClient] Ignore drop-in UI test due to timeout; Default OAuth 2.0 client to persist

* Fix the transition between persistence enabled and disabled in AWSKeyValueStore

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Update changelog for 2.12.5; Add mobile client; Remove IoT metrics

* Skip reserved keynames (#791)

* Skip reserved keynames

* Add log when reserved key names are encountered

* Bump version 2.12.5 (#792)
awsmobilesdk pushed a commit to awsmobilesdk/aws-sdk-android that referenced this pull request Apr 12, 2020
…ion username (aws-amplify#765)

The connection username is used as user metadata by the service for the purpose of metrics calculation.
awsmobilesdk pushed a commit to awsmobilesdk/aws-sdk-android that referenced this pull request Apr 12, 2020
* Secure information stored in SharedPreferences

* Lower aws-android-sdk-core-test compile and target sdk version to 27

* Add a symlink to android-23.jar for core

* Add a gradle task that creates a symlink to android-23.jar for AWS Core

* Fix the gradle task that creates symbolic link to android-23.jar

* Change config.yml to setup android-23

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Fix pom.xml

* Improve exception handling in AWSKeyValueStore

* [2.12.3] Bump the patch version of 2.12.z

* Update 2.12.3 CHANGELOG

* Add the missing bucket prefixes to CleanupBucketIntegrationTests

* Fix a bug where migrating expirationDate in CognitoCachingCredentialsProvider crashes

* [2.12.4] Update changelog and bump version

* Annotate code specific to API Level 23 and above in AWSKeyValueStore

* Added API to accept key-value pairs which are appended to the connection username (aws-amplify#765)

The connection username is used as user metadata by the service for the purpose of metrics calculation.

* build android sdk with android-10 (aws-amplify#782)

* Add sign out options

* [MobileClient] Cleanup javadocs and remove unnecessary try..catch blocks

* [MobileClient] Add developer authenticated identities to federatedSignIn fixes aws-amplify#577

* [MobileClient] Add test for developer authenticated idenities federatedSignIn

* [MobileClient] Persist identity id for developer authenticated identities

* [MobileClient] Add AWSMobileClient as client usage tracker in user agent

* [MobileClient] Add device operations; Add error message to ReturningRunnable

* [MobileClient] Add global sign-out functionality

* [MobileClient] Add custom role arn to settings in federated sign-in persistence

* [MobileClient] Add forgot password test; Fix sign out globally test

* [MobileClient] [Userpools] [CognitoAuth] Add HostedUI and OAuth 2.0 code grant flow support

[MobileClient]
Add HostedUI and OAuth 2.0 code grant flow support

[Userpools]
Fix threading issues reported in issue aws-amplify#722

[CognitoAuth]
Added methods to reset AuthHandler and get session without launching UI
Fix erroneous user cancelled when redirecting back to app fixes aws-amplify#328

* [MobileClient] Fix multiple adds of SignInProvider to provider list fixes aws-amplify#766

* [MobileClient] Fix git merge issues

* [MobileClient] Fix integration tests for new configuration

* [CognitoAuth] Fix NPE when ASF feature turned off

* [MobileClient] Finalize APIs before release, add persistence flag to OAuth 2.0 and HostedUI features

* [AuthSDKs] Update maven repositories in pom to maven.google.com

* [Core] Fix NPE when setting persistence in AWSKeyValueStore after initialization

* [MobileClient] Ignore manual tests in automation

* [MobileClient] Ignore drop-in UI test due to timeout; Default OAuth 2.0 client to persist

* Fix the transition between persistence enabled and disabled in AWSKeyValueStore

* Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI

* Update changelog for 2.12.5; Add mobile client; Remove IoT metrics

* Skip reserved keynames (aws-amplify#791)

* Skip reserved keynames

* Add log when reserved key names are encountered

* Bump version 2.12.5 (aws-amplify#792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iot Issues with the AWS Android SDK for Internet of Things (IoT)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants