Skip reserved keynames #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
approved these changes
Mar 14, 2019
aws-android-sdk-iot/src/main/java/com/amazonaws/mobileconnectors/iot/AWSIotMqttManager.java
Show resolved
Hide resolved
mutablealligator
approved these changes
Mar 14, 2019
mutablealligator
pushed a commit
that referenced
this pull request
Mar 14, 2019
* Secure information stored in SharedPreferences * Lower aws-android-sdk-core-test compile and target sdk version to 27 * Add a symlink to android-23.jar for core * Add a gradle task that creates a symlink to android-23.jar for AWS Core * Fix the gradle task that creates symbolic link to android-23.jar * Change config.yml to setup android-23 * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Fix pom.xml * Improve exception handling in AWSKeyValueStore * [2.12.3] Bump the patch version of 2.12.z * Update 2.12.3 CHANGELOG * Add the missing bucket prefixes to CleanupBucketIntegrationTests * Fix a bug where migrating expirationDate in CognitoCachingCredentialsProvider crashes * [2.12.4] Update changelog and bump version * Annotate code specific to API Level 23 and above in AWSKeyValueStore * Added API to accept key-value pairs which are appended to the connection username (#765) The connection username is used as user metadata by the service for the purpose of metrics calculation. * build android sdk with android-10 (#782) * Add sign out options * [MobileClient] Cleanup javadocs and remove unnecessary try..catch blocks * [MobileClient] Add developer authenticated identities to federatedSignIn fixes #577 * [MobileClient] Add test for developer authenticated idenities federatedSignIn * [MobileClient] Persist identity id for developer authenticated identities * [MobileClient] Add AWSMobileClient as client usage tracker in user agent * [MobileClient] Add device operations; Add error message to ReturningRunnable * [MobileClient] Add global sign-out functionality * [MobileClient] Add custom role arn to settings in federated sign-in persistence * [MobileClient] Add forgot password test; Fix sign out globally test * [MobileClient] [Userpools] [CognitoAuth] Add HostedUI and OAuth 2.0 code grant flow support [MobileClient] Add HostedUI and OAuth 2.0 code grant flow support [Userpools] Fix threading issues reported in issue #722 [CognitoAuth] Added methods to reset AuthHandler and get session without launching UI Fix erroneous user cancelled when redirecting back to app fixes #328 * [MobileClient] Fix multiple adds of SignInProvider to provider list fixes #766 * [MobileClient] Fix git merge issues * [MobileClient] Fix integration tests for new configuration * [CognitoAuth] Fix NPE when ASF feature turned off * [MobileClient] Finalize APIs before release, add persistence flag to OAuth 2.0 and HostedUI features * [AuthSDKs] Update maven repositories in pom to maven.google.com * [Core] Fix NPE when setting persistence in AWSKeyValueStore after initialization * [MobileClient] Ignore manual tests in automation * [MobileClient] Ignore drop-in UI test due to timeout; Default OAuth 2.0 client to persist * Fix the transition between persistence enabled and disabled in AWSKeyValueStore * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Update changelog for 2.12.5; Add mobile client; Remove IoT metrics * Skip reserved keynames (#791) * Skip reserved keynames * Add log when reserved key names are encountered * Bump version 2.12.5 (#792)
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
* Skip reserved keynames * Add log when reserved key names are encountered
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
* Secure information stored in SharedPreferences * Lower aws-android-sdk-core-test compile and target sdk version to 27 * Add a symlink to android-23.jar for core * Add a gradle task that creates a symlink to android-23.jar for AWS Core * Fix the gradle task that creates symbolic link to android-23.jar * Change config.yml to setup android-23 * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Fix pom.xml * Improve exception handling in AWSKeyValueStore * [2.12.3] Bump the patch version of 2.12.z * Update 2.12.3 CHANGELOG * Add the missing bucket prefixes to CleanupBucketIntegrationTests * Fix a bug where migrating expirationDate in CognitoCachingCredentialsProvider crashes * [2.12.4] Update changelog and bump version * Annotate code specific to API Level 23 and above in AWSKeyValueStore * Added API to accept key-value pairs which are appended to the connection username (aws-amplify#765) The connection username is used as user metadata by the service for the purpose of metrics calculation. * build android sdk with android-10 (aws-amplify#782) * Add sign out options * [MobileClient] Cleanup javadocs and remove unnecessary try..catch blocks * [MobileClient] Add developer authenticated identities to federatedSignIn fixes aws-amplify#577 * [MobileClient] Add test for developer authenticated idenities federatedSignIn * [MobileClient] Persist identity id for developer authenticated identities * [MobileClient] Add AWSMobileClient as client usage tracker in user agent * [MobileClient] Add device operations; Add error message to ReturningRunnable * [MobileClient] Add global sign-out functionality * [MobileClient] Add custom role arn to settings in federated sign-in persistence * [MobileClient] Add forgot password test; Fix sign out globally test * [MobileClient] [Userpools] [CognitoAuth] Add HostedUI and OAuth 2.0 code grant flow support [MobileClient] Add HostedUI and OAuth 2.0 code grant flow support [Userpools] Fix threading issues reported in issue aws-amplify#722 [CognitoAuth] Added methods to reset AuthHandler and get session without launching UI Fix erroneous user cancelled when redirecting back to app fixes aws-amplify#328 * [MobileClient] Fix multiple adds of SignInProvider to provider list fixes aws-amplify#766 * [MobileClient] Fix git merge issues * [MobileClient] Fix integration tests for new configuration * [CognitoAuth] Fix NPE when ASF feature turned off * [MobileClient] Finalize APIs before release, add persistence flag to OAuth 2.0 and HostedUI features * [AuthSDKs] Update maven repositories in pom to maven.google.com * [Core] Fix NPE when setting persistence in AWSKeyValueStore after initialization * [MobileClient] Ignore manual tests in automation * [MobileClient] Ignore drop-in UI test due to timeout; Default OAuth 2.0 client to persist * Fix the transition between persistence enabled and disabled in AWSKeyValueStore * Enable core, cognitoidentityprovider and cognitoauth integration tests on CircleCI * Update changelog for 2.12.5; Add mobile client; Remove IoT metrics * Skip reserved keynames (aws-amplify#791) * Skip reserved keynames * Add log when reserved key names are encountered * Bump version 2.12.5 (aws-amplify#792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.