Pom aws sdk dependency and prep java plugin for release #324
Conversation
pom.xml
Outdated
| @@ -37,7 +37,7 @@ | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
| <awssdk.version>2.13.18</awssdk.version> | |||
| <awssdk.version>2.15.0</awssdk.version> | |||
There was a problem hiding this comment.
curious why we need to this?
There was a problem hiding this comment.
regularly bumping sdk allows handlers be up to date with the latest in the base sdk. can also do a range of versions but then builds arent really reproducible. doing a bit of research into http://www.mojohaus.org/versions-maven-plugin/ now to see if this can make this less of a manual thing
There was a problem hiding this comment.
Version ranges in Bill of Material (BOM) poms aren't supported: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms
One has to specify a specific version number for the project imported.
There was a problem hiding this comment.
We should probably specify a bill of materials in the pom.xml for the resource provider projects as well. Maven's dependency management works on a "nearest wins" strategy: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html, so if we had explicitly declared dependencies for the entire aws sdk package in the resource provider as well, that version would override since it is closer to the root.
Co-authored-by: Pat Myron <PatMyron@users.noreply.github.com>
|
Used command |
|
Is this alright to do a bit of a version bump spree? not sure if we risk anything from doing this |
|
This looks to be ok after doing some manual testing in my account. Will follow up with some contract testing of an existing known good resource to verify |
pom.xml
Outdated
| <awssdk.version>2.15.19</awssdk.version> | ||
| <checkstyle.version>8.36.2</checkstyle.version> | ||
| <commons-io.version>2.8.0</commons-io.version> | ||
| <jackson.version>2.12.0-rc1</jackson.version> |
There was a problem hiding this comment.
why we use rc release? is it official?
Issue #, if available:
Description of changes: Bumping PyPI package version along with giving the java sdk a version bump. Planning on releasing this today.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.