Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pom aws sdk dependency and prep java plugin for release #324

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Pom aws sdk dependency and prep java plugin for release #324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
123a913
Pom aws sdk dependency and prep java plugin for release
Oct 30, 2020
6a3af76
Update pom.xml
Oct 30, 2020
2baf4d1
Use maven command to update deps
Oct 31, 2020
8a0fc7e
Use latest non-rc for jackson
Nov 4, 2020
6708f30
Bump template for pom file for mockito as well
Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<maven.compiler.target>1.8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<awssdk.version>2.13.18</awssdk.version>
<awssdk.version>2.15.0</awssdk.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we need to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regularly bumping sdk allows handlers be up to date with the latest in the base sdk. can also do a range of versions but then builds arent really reproducible. doing a bit of research into http://www.mojohaus.org/versions-maven-plugin/ now to see if this can make this less of a manual thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#267 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version ranges in Bill of Material (BOM) poms aren't supported: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#bill-of-materials-bom-poms

One has to specify a specific version number for the project imported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably specify a bill of materials in the pom.xml for the resource provider projects as well. Maven's dependency management works on a "nearest wins" strategy: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html, so if we had explicitly declared dependencies for the entire aws sdk package in the resource provider as well, that version would override since it is closer to the root.

johnttompkins marked this conversation as resolved.
Show resolved Hide resolved
<checkstyle.version>8.29</checkstyle.version>
<commons-io.version>2.6</commons-io.version>
<jackson.version>2.10.1</jackson.version>
Expand Down
2 changes: 1 addition & 1 deletion python/rpdk/java/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import logging

__version__ = "2.0.2"
__version__ = "2.0.3"

logging.getLogger(__name__).addHandler(logging.NullHandler())