Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest log printing option #491

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Update pytest log printing option #491

merged 2 commits into from
Jul 31, 2020

Conversation

LaikaN57
Copy link
Contributor

Issue #, if available:
The following warning is generated when running cfn test:

================================================================= warnings summary ==================================================================
.venv/lib/python3.7/site-packages/_pytest/logging.py:499
  .venv/lib/python3.7/site-packages/_pytest/logging.py:499: PytestDeprecationWarning: --no-print-logs is deprecated and scheduled for removal in pytest 6.0.
  Please use --show-capture instead.
    _issue_warning_captured(NO_PRINT_LOGS, self._config.hook, stacklevel=2)

Description of changes:
Migrate to new pytest option to resolve warning.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LaikaN57
Copy link
Contributor Author

And just for reference, here is my env which results in pytest==5.4.3 currently:

aws-sam-cli==0.53.0
awscli==1.18.86
black
boto3==1.14.9
botocore==1.17.9
#cloudformation-cli>0.1.4
cloudformation-cli @ git+https://github.com/aws-cloudformation/cloudformation-cli.git@85dba80439e044f65e294af65d36fa0934151bad
cloudformation-cli-python-lib==2.0.0
cloudformation-cli-python-plugin==2.0.0
docker==3.7.3
logmatic-python==0.1.7

@LaikaN57 LaikaN57 changed the title Update pytest log printing option WIP: Update pytest log printing option Jul 16, 2020
@LaikaN57 LaikaN57 marked this pull request as draft July 23, 2020 18:04
@LaikaN57 LaikaN57 changed the title WIP: Update pytest log printing option Update pytest log printing option Jul 23, 2020
Update branch with latest in upstream master
@LaikaN57 LaikaN57 marked this pull request as ready for review July 27, 2020 17:23
@PatMyron PatMyron requested a review from ammokhov July 31, 2020 00:12
@PatMyron
Copy link
Contributor

PatMyron commented Jul 31, 2020

pytest 6.0 released this week, so --no-print-logs is getting more urgent to fix, especially since we required 6.0+ for next release

@ammokhov
Copy link
Contributor

pytest 6.0 released this week, so this is getting more urgent to fix, especially since we required it for next release

bumped the dependency here #518

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change, thank you

@ammokhov ammokhov merged commit e0bc5c8 into aws-cloudformation:master Jul 31, 2020
@LaikaN57 LaikaN57 deleted the patch-2 branch July 31, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants