Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing default lambda memory size #518

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Jul 30, 2020

Issue #, if available: #510

Description of changes:

increasing the default memory size

bumping pytest to 6.x as annotations were not recognized as callable pytest-dev/pytest#7473

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov merged commit 48832b4 into aws-cloudformation:master Jul 30, 2020
@ammokhov ammokhov deleted the memory-size branch July 30, 2020 21:23
@@ -5,7 +5,7 @@ ipdb>=0.12
# testing tools
pylint>=2.3.1
coverage>=4.5.4
pytest>=5.3.5
pytest>=6.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaikaN57
Copy link
Contributor

@ammokhov We have to manually apply this config to existing CFN RPs correct? If so, is there a better way that CFN RP developers could get notified about these types of changes?

cc: @jotompki

@ammokhov
Copy link
Contributor Author

@ammokhov We have to manually apply this config to existing CFN RPs correct? If so, is there a better way that CFN RP developers could get notified about these types of changes?

cc: @jotompki

we dont, it's a common package and if other prs do not have merge conflicts then you can just restart travis job

@LaikaN57
Copy link
Contributor

LaikaN57 commented Jul 31, 2020

@ammokhov Sorry, I did not understand your response, let me re-ask my question... There was a similar template change (rpdk protocol upgrade, if i remember correctly) where the new template was not applied to existing CFN RP flies that end-users made with cfn-cli (ie. cfn generate had no effect on existing CFN RP files.)

I am asking if this template change will similarly need to be manually applied to end-user CFN RPs files or if the cfn generate command will overwrite the existing files that this template defines. To change protocol version from my above example, I needed to manually edit the .rpdk-config file.

@ammokhov
Copy link
Contributor Author

ammokhov commented Aug 1, 2020

@ammokhov Sorry, I did not understand your response, let me re-ask my question... There was a similar template change (rpdk protocol upgrade, if i remember correctly) where the new template was not applied to existing CFN RP flies that end-users made with cfn-cli (ie. cfn generate had no effect on existing CFN RP files.)

I am asking if this template change will similarly need to be manually applied to end-user CFN RPs files or if the cfn generate command will overwrite the existing files that this template defines. To change protocol version from my above example, I needed to manually edit the .rpdk-config file.

Sorry, ignore previous reply I misunderstood your question.
you are right cfn generate will not modify existing template.yml which should be manually changed, as this file is generate once on the project creation. This is a static file and not a subject to change based off schema modifications like ResourceModel or resource specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants