Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds telemetry events to submitter and adaptor #40

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Mar 19, 2024

What was the problem/requirement? (What/Why)

We can't currently tell if anyone is using KeyShot submitters / adaptors

What was the solution? (How)

Uses changes from aws-deadline/deadline-cloud#205 to capture more package information when sending telemetry data, and changes from aws-deadline/deadline-cloud#212 to opt out of telemetry from an environment variable.

What is the impact of this change?

We can better tell how customers use our software and if they use KeyShot

How was this change tested?

  • ran the integrated submitter, and submitted a job, verifying it wrote telemetry (and didn't when opted out)
  • ran the adaptor, confirming it wrote telemetry, huge thanks to @moorec-aws for testing this

Was this change documented?

Updated README with opt out instructions

Is this a breaking change?

No

@marofke marofke force-pushed the marofke/telemetry-updates branch 4 times, most recently from 3847564 to d6c28f0 Compare March 21, 2024 22:18
@marofke marofke marked this pull request as ready for review March 21, 2024 22:21
@marofke marofke requested a review from a team as a code owner March 21, 2024 22:21
Signed-off-by: Caden Marofke <marofke@amazon.com>
@marofke marofke merged commit 00ff0cd into mainline Mar 22, 2024
12 checks passed
@marofke marofke deleted the marofke/telemetry-updates branch March 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants