feat: Adds common data to telemetry events #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
force-pushed
the
marofke/telemetry-updates
branch
from
914a728
to
b5cb90a
Compare
marofke
changed the title
marofke
changed the title
marofke
force-pushed
the
marofke/telemetry-updates
branch
from
b5cb90a
to
26ac7e0
Compare
mwiebe
previously approved these changes
Mar 13, 2024
jericht
previously approved these changes
Mar 13, 2024
marofke
force-pushed
the
marofke/telemetry-updates
branch
from
26ac7e0
to
cfcdca7
Compare
mwiebe
approved these changes
Mar 13, 2024
Signed-off-by: Caden Marofke <marofke@amazon.com>
marofke
force-pushed
the
marofke/telemetry-updates
branch
from
cfcdca7
to
24317b7
Compare
mwiebe
approved these changes
Mar 13, 2024
jericht
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
Merged
Merged
Merged
Merged
Merged
npmacl
pushed a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Caden Marofke <marofke@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We need to refine our telemetry metrics to better isolate events.
What was the solution? (How)
Be more descriptive of event types, and add common data that is included in every request (the intent is to capture package versions of other libraries that use this library, such as our integrated submitters and adaptors)
See these other PRs for how we'll build off of these changes:
What is the impact of this change?
We can more clearly pinpoint what kind of flows users are using, and on what versions of our software they are using.
How was this change tested?
Manually tested against my own deployment, confirmed test data showed up.
Was this change documented?
N/A
Is this a breaking change?
No