feat: Adds telemetry to submitter and adaptor #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marofke
force-pushed
the
marofke/telemetry-updates
branch
6 times, most recently
from
6aa0d25
to
8b221e3
Compare
Signed-off-by: Caden Marofke <marofke@amazon.com>
marofke
force-pushed
the
marofke/telemetry-updates
branch
from
8b221e3
to
c408e45
Compare
ddneilson
approved these changes
Mar 20, 2024
gahyusuh
approved these changes
Mar 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We can't currently tell if anyone is using unreal engine submitters / adaptors
What was the solution? (How)
Uses changes from aws-deadline/deadline-cloud#205 to capture more package information when sending telemetry data, and changes from aws-deadline/deadline-cloud#212 to opt out of telemetry from an environment variable.
Note, I could not for the life of me figure out where to get the Engine Version number. I looked through the python api but all I could find was the VersionInfoHandler which has no information and appears to only report the version of a specific object given to it.
What is the impact of this change?
We can better tell how customers use our software and if they use unreal engine
How was this change tested?
Was this change documented?
Updated README with opt out instructions
Is this a breaking change?
No