Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add telemetry data to submitter and adaptor #114

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Mar 13, 2024

What was the problem/requirement? (What/Why)

We can't currently tell if anyone is using Maya submitters / adaptors

What was the solution? (How)

Uses changes from aws-deadline/deadline-cloud#205 to capture more package information when sending telemetry data, and changes from aws-deadline/deadline-cloud#212 to opt out of telemetry from an environment variable.

What is the impact of this change?

We can better tell how customers use our software and if they use Maya

How was this change tested?

  • ran the integrated submitter, and submitted a job, verifying it wrote telemetry (and didn't when opted out)
  • ran the adaptor locally, confirming it wrote telemetry (and didn't when opted out)
  • ran unit tests using deadline-cloud changes from mainline, they passed

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

N/A

Was this change documented?

Is this a breaking change?

@marofke marofke force-pushed the marofke/telemetry-updates branch 13 times, most recently from 8b16834 to fd3e96f Compare March 19, 2024 22:21
@marofke marofke marked this pull request as ready for review March 19, 2024 22:23
@marofke marofke requested a review from a team as a code owner March 19, 2024 22:23
Signed-off-by: Caden Marofke <marofke@amazon.com>
@marofke marofke merged commit d853496 into mainline Mar 20, 2024
6 checks passed
@marofke marofke deleted the marofke/telemetry-updates branch March 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants