fix!: Terminating all VFS processes when cleaning up session #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
marofke
reviewed
Feb 7, 2024
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
marofke
approved these changes
Feb 8, 2024
mwiebe
previously approved these changes
Feb 8, 2024
marofke
requested changes
Feb 8, 2024
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
natmatn
changed the title
marofke
approved these changes
Feb 21, 2024
gmchale79
approved these changes
Feb 21, 2024
This was referenced Feb 22, 2024
Closed
Merged
Merged
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
* fix!: Terminating all VFS processes when cleaning up session --------- Signed-off-by: Nathan Matthews <natmatn@amazon.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
jusiskin
pushed a commit
to jusiskin/deadline-cloud-worker-agent
that referenced
this pull request
Sep 4, 2024
Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Originally, the best place to terminate deadline VFS processes was in the output sync step. However, with the introduction of step-step dependent jobs, the deadline VFS instances were being terminated between tasks. This caused the jobs to fail as the expected asset roots were no longer mounted when multiple tasks were run in a step.
What was the solution? (How)
Moved the termination call from the deadline-cloud sync_outputs call to the deadline-cloud-worker-agent's session cleanup method.
What is the impact of this change?
Jobs using the "VIRTUAL" asset-loading-method will now support step-step dependencies
How was this change tested?
Was this change documented?
No
Is this a breaking change?
yes, needs this commit from deadline-cloud to work
aws-deadline/deadline-cloud@ef782bf