fix: Removing VFS termination from sync_outputs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
marofke
reviewed
Feb 7, 2024
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
Signed-off-by: Nathan Matthews <natmatn@amazon.com>
mwiebe
approved these changes
Feb 8, 2024
YutongLi291
pushed a commit
that referenced
this pull request
Feb 14, 2024
* fix: Removing VFS termination from sync_outputs Signed-off-by: Nathan Matthews <natmatn@amazon.com> * Adding session cleanup function to terminate fus3 processes Signed-off-by: Nathan Matthews <natmatn@amazon.com> * Fixing lint warning Signed-off-by: Nathan Matthews <natmatn@amazon.com> --------- Signed-off-by: Nathan Matthews <natmatn@amazon.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two part PR, with the change in the worker agent needing to be merged first
aws-deadline/deadline-cloud-worker-agent#149
What was the problem/requirement? (What/Why)
Originally, the best place to terminate deadline VFS processes was in the output sync step. However, with the introduction of step-step dependent jobs, the deadline VFS instances were being terminated between tasks. This caused the jobs to fail as the expected asset roots were no longer mounted when multiple tasks were run in a step.
What was the solution? (How)
Moved the termination call from the deadline-cloud sync_outputs call to the deadline-cloud-worker-agent's session cleanup method.
What is the impact of this change?
Jobs using the "VIRTUAL" asset-loading-method will now support step-step dependencies
How was this change tested?
Was this change documented?
No
Is this a breaking change?
No, but without the corresponding change in deadline-cloud-worker-agent, session directories won't be properly cleaned up.