-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: prep for rootPathFormat becoming ALL UPPERS #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epmog
force-pushed
the
UPDATE_PATH_FORMAT
branch
from
March 21, 2024 03:54
281bc89
to
4e31684
Compare
jericht
previously approved these changes
Mar 21, 2024
epmog
force-pushed
the
UPDATE_PATH_FORMAT
branch
4 times, most recently
from
March 21, 2024 05:09
604b693
to
64a53b7
Compare
epmog
force-pushed
the
UPDATE_PATH_FORMAT
branch
from
March 21, 2024 05:20
64a53b7
to
b570246
Compare
jericht
approved these changes
Mar 21, 2024
ddneilson
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're sure that this one is changing? Things are moving quick, so it's not clear to me.
marofke
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🦈
** BREAKING CHANGE ** * The PathFormat enum's values went from all lowercase to all uppercase * The source_path_root in the path mapping rules return value from sync_inputs went from all lowercase to all uppercase Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
epmog
force-pushed
the
UPDATE_PATH_FORMAT
branch
from
March 21, 2024 18:48
b570246
to
9c55436
Compare
baxeaz
pushed a commit
that referenced
this pull request
Mar 21, 2024
** BREAKING CHANGE ** * The PathFormat enum's values went from all lowercase to all uppercase * The source_path_root in the path mapping rules return value from sync_inputs went from all lowercase to all uppercase Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com>
Merged
baxeaz
added a commit
that referenced
this pull request
Mar 22, 2024
* Switch to running deadline_vfs as os_user Signed-off-by: Brian Axelson <baxelson@amazon.com> * feat(job_attachments): enhance handling S3 timeout errors and BotoCoreError (#206) Improve error handling for S3 requests by - adding "retries" configuration to the S3 client - adding BotoCoreError handling to cover S3 timeout errors (e.g., ReadTimeoutError, ConnectTimeoutError) Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * fix(job_attachments): Use files' last modification time to identify output files to be synced (#211) Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * chore(deps): update python-semantic-release requirement (#216) Updates the requirements on [python-semantic-release](https://github.com/python-semantic-release/python-semantic-release) to permit the latest version. - [Release notes](https://github.com/python-semantic-release/python-semantic-release/releases) - [Changelog](https://github.com/python-semantic-release/python-semantic-release/blob/master/CHANGELOG.md) - [Commits](python-semantic-release/python-semantic-release@v8.7.0...v9.2.2) --- updated-dependencies: - dependency-name: python-semantic-release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * chore(release): 0.41.0 (#217) Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * chore(deps): update coverage[toml] requirement from ~=7.2 to ~=7.4 (#156) Updates the requirements on [coverage[toml]](https://github.com/nedbat/coveragepy) to permit the latest version. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.3.0...7.4.0) --- updated-dependencies: - dependency-name: coverage[toml] dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * fix: Make StorageProfileOperatingSystemFamily enum case-insensitive Signed-off-by: Caden Marofke <marofke@amazon.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * ci: add gpg signing of build artifacts (#218) Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * feat!: prep for rootPathFormat becoming ALL UPPERS (#222) ** BREAKING CHANGE ** * The PathFormat enum's values went from all lowercase to all uppercase * The source_path_root in the path mapping rules return value from sync_inputs went from all lowercase to all uppercase Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com> Signed-off-by: Brian Axelson <baxelson@amazon.com> * CR Feedback Signed-off-by: Brian Axelson <baxelson@amazon.com> * Cleaning up a few more 'executing the job' cases Signed-off-by: Brian Axelson <baxelson@amazon.com> --------- Signed-off-by: Brian Axelson <baxelson@amazon.com> Signed-off-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com> Signed-off-by: Caden Marofke <marofke@amazon.com> Signed-off-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com> Co-authored-by: Gahyun Suh <132245153+gahyusuh@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: client-software-ci <129794699+client-software-ci@users.noreply.github.com> Co-authored-by: Caden Marofke <marofke@amazon.com> Co-authored-by: Charles Moore <122481442+moorec-aws@users.noreply.github.com> Co-authored-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
epmog
added a commit
that referenced
this pull request
Mar 25, 2024
This reverts commit d49c885. Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
epmog
added a commit
that referenced
this pull request
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
API model for rootPathFormat is changing from lowercase to uppercase, so we need to prep ahead of time so that we support both when the swap happens.
What was the solution? (How)
windows
) that it would see if the uppercase version exists.What is the impact of this change?
How was this change tested?
Added tests around the
_missing_
feature of the enum, as well as the DeadlineClient create_job shimI then attempted to submit job bundles using the old model, and confirmed that it changed the request to use the lowercase version.
Was this change documented?
N/A
Is this a breaking change?
This is a breaking change since we're changing the PathFormat enum's values and the format of the strings returned for the path mapping rules in
sync_inputs
(even though the only known dependency handles this already).