revert!: "feat!: prep for rootPathFormat becoming ALL UPPERS (#222)" #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d49c885. Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
epmog
force-pushed
the
revert_path_format_uppers
branch
from
0581cbe
to
057c6ab
Compare
marofke
approved these changes
Mar 25, 2024
gahyusuh
approved these changes
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d49c885. PR #222
What was the problem/requirement? (What/Why)
service change is no longer going through, so this commit is no longer needed.
What was the solution? (How)
git revert!
What is the impact of this change?
posix will forever be whispered
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
technically, since PathFormats are returned as lowercased from sync_inputs