-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDON] - Keda #245
Comments
I'd love to hear more about what was confusing or complex |
@bryantbiggs I have no issue with using
|
You can still deploy KEDA with this module: module "eks_blueprints_addons" {
source = "aws-ia/eks-blueprints-addons/aws"
cluster_name = module.eks.cluster_name
cluster_endpoint = module.eks.cluster_endpoint
cluster_version = module.eks.cluster_version
oidc_provider_arn = module.eks.oidc_provider_arn
... # Truncated for brevity
# Pass in any number of Helm charts to be created for those that are not natively supported
helm_releases = {
keda = {
chart = "keda"
chart_version = "1.4.2"
repository = "https://kedacore.github.io/charts"
description = "Keda helm Chart deployment"
namespace = "keda"
create_namespace = true
}
}
tags = local.tags
} |
I agree this can be done this way, but I thought the use case for EKS Blueprints Addons is providing a simple way of managing addons commonly used. |
@lordz-md I second support for KEDA as a "native" add-on. For a functional KEDA controller there's more than just installing the helm chart. In order to e.g use the Cloudwatch scaler (or the SQS scaler, or the DynamoDB scaler etc etc) a whole bunch of IAM policies + IRSA mappings needs to be configured for it, which seems to be right in the realm of this module. |
Forgot to mention, can someone re-open this issue? 🙏 |
Re-oppened. |
@blakepettersson, if you are ok, I can add your arguments to the issue description |
@lordz-md feel free to do so! I could look into a potential implementation if it's something @bryantbiggs / @csantanapr would be interested in. |
we will discuss it within the team and report back on whether KEDA will be adopted natively here or not. thank you! |
Any movement on this one? This would be a much appreciated addition. |
at this time, we do not plan on adding KEDA directly into this project - however, users can still use this project to deploy KEDA as shown here #245 (comment) |
Something which may be of interest is the addition of docs for what will be the new and improved aws auth in KEDA in kedacore/keda-docs#1251 |
Hey! Installing KEDA "as it is" is quite easy because helm just works, but for enabling features like IRSA Role assumption you need to create all boring stuff (role, relations, oidc provider) and this module is already creating them for other workloads. I'd suggest including KEDA as add-on and creating at least a role for it, federated with given OIDC for allowing IRSA Role assumption out-of-the-box. If reconsider this and accept KEDA as add-on, I'm willing to open a PR adding it |
Hey Guys I appreciate if we could open this issue again. KEDA provides event-driven autoscaling for Kubernetes workloads, supporting a wide range of scalers like AWS SQS, CloudWatch, and DynamoDB. This integration offers significant benefits:
Implementation Details enable_keda = true This configuration ensures KEDA's installation, including all the necessary (just helm chart installtion). Pull Request I believe this addition will significantly enhance the repository's functionality and provide great value to the users. Thank you for considering this proposal. |
Community Note
What is the outcome that you are trying to reach?
KEDA scaling the number of pods in the cluster based on the number of events that need to be processed this in combination with Karpenter can lead to better application performance and/or cost optimization
Describe the solution you would like
Have Keda installation available as simple as
enable_keda = true
Describe alternatives you have considered
Tried using aws-ia/eks-blueprints-addon/aws but that is confusing and adds extra complexity
Additional context
For a functional KEDA controller there's more than just installing the helm chart. In order to e.g use the Cloudwatch scaler (or the SQS scaler, or the DynamoDB scaler etc etc) a whole bunch of IAM policies + IRSA mappings needs to be configured for it, which seems to be right in the realm of this module.
The text was updated successfully, but these errors were encountered: