Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about new AWS auth #1251

Merged
merged 16 commits into from
Jan 9, 2024
Merged

Add documentation about new AWS auth #1251

merged 16 commits into from
Jan 9, 2024

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to kedacore/keda#4134

@JorTurFer
Add documentation about new AWS auth
8757f30 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner October 18, 2023 22:17
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6901c33
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6595efa31eb014000830d558
😎 Deploy Preview https://deploy-preview-1251--keda.netlify.app/docs/2.13/authentication-providers/aws
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer
Update ignores
e024e01 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
tomkerkhove
tomkerkhove reviewed Oct 19, 2023
View reviewed changes
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
JorTurFer and others added 2 commits October 19, 2023 10:24
@JorTurFer @tomkerkhove
Apply suggestions from code review
a836f12 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Merge branch 'main' into add.aws
6af4a87 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
blakepettersson
blakepettersson reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@blakepettersson blakepettersson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far 😄 Just a few comments

content/docs/2.13/authentication-providers/aws-eks.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws-kiam.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
@blakepettersson
Copy link
Contributor

Another thing, for all AWS scalers it would be good to clarify that all of the roleArns on said scalers are deprecated and should not be used (or perhaps even an error if used with the aws TriggerAuthentication?)

JorTurFer and others added 2 commits October 20, 2023 00:27
@JorTurFer @blakepettersson
Update content/docs/2.13/authentication-providers/aws.md
5de5670 
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer @blakepettersson
Update content/docs/2.13/authentication-providers/aws.md
dd71f59 
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer @zroubalik @blakepettersson
Apply suggestions from code review
999e889 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

Another thing, for all AWS scalers it would be good to clarify that all of the roleArns on said scalers are deprecated and should not be used (or perhaps even an error if used with the aws TriggerAuthentication?)

This is a good point and I missed it, tomorrow I'll add a note on them

@JorTurFer @blakepettersson
Update content/docs/2.13/authentication-providers/aws.md
75a2543 
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@blakepettersson blakepettersson mentioned this pull request Oct 28, 2023
Closed
@blakepettersson blakepettersson mentioned this pull request Nov 20, 2023
Closed
4 tasks
JorTurFer and others added 3 commits December 31, 2023 20:04
@JorTurFer
update docs
509ec2d 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Update docs
b15f971 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Merge branch 'main' into add.aws
89875bb 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

PTAL @zroubalik , @tomkerkhove @blakepettersson @ThaSami
I've been working on this feature and it's ready to review. I've addressed all the comments here and also in the issue (or at least I hope so)

@JorTurFer JorTurFer mentioned this pull request Jan 1, 2024
Merged
6 tasks
@tomkerkhove
Copy link
Member

Can you please remind me why 1 auth provider is removed in KEDA v2.15 and the other one in KEDA v3?

@JorTurFer
Copy link
Member Author

Can you please remind me why 1 auth provider is removed in KEDA v2.15 and the other one in KEDA v3?

It's because KIAM is deprecated, so we can remove aws-kiam after the proper announce (and 2 versiones) and IRSA still works (aws-eks uses IRSA), but we decided to create another auth (although it uses IRSA too) to redesign the current approach, unifying the concept with Azure/GCP approaches instead of current approach. This is because aws-eks uses information from TriggerAuthentication but also from trigger.metadata for authentication stuff (for example, if you want to override the roleArn, aws-eks takes it from trigger.metadata instead of TriggerAuthentication)
As aws-eks doesn't use a deprecated technology, we decided to keep it available until KEDA v3, where we can introduce breaking changes with freedom.

JorTurFer and others added 2 commits January 2, 2024 20:21
@JorTurFer @tomkerkhove
Apply suggestions from code review
ae1ca07 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
use discussion instead of issues
535ba02 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
zroubalik
zroubalik reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws-kiam.md Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Show resolved Hide resolved
content/docs/2.13/authentication-providers/aws.md Outdated Show resolved Hide resolved
@JorTurFer
Update title
369dd80 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Rename auth titles
7c81796 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
apply feedback
6901c33 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
tomkerkhove
tomkerkhove approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomkerkhove tomkerkhove merged commit b266cb6 into kedacore:main Jan 9, 2024
8 checks passed
@JorTurFer JorTurFer deleted the add.aws branch January 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@blakepettersson blakepettersson blakepettersson left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @blakepettersson @tomkerkhove @zroubalik