Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Override karpenter instance profile name #325

Merged
merged 5 commits into from
Feb 2, 2024
Merged

fix: Override karpenter instance profile name #325

merged 5 commits into from
Feb 2, 2024

Commits on Dec 4, 2023

  1. fix: Override karpenter instance profile name 

    There is a pre-existing variable in `karpenter` which can override the
instance profile name, but it's only applied for the Helm chart. For
the instance profile name itself it's not used. We use
`instance_profile_name` as a default, and only if it is not set
`local.karpenter_node_iam_role_name` is instead used.
    @blakepettersson
    blakepettersson committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    87ae05b View commit details
    Browse the repository at this point in the history

  2. fix: Use try with var.karpenter_node.instance_profile_name

    @blakepettersson
    blakepettersson committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4ea3379 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. refactor: no need for coalesce

    @blakepettersson
    blakepettersson committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    187c1d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. fix: Clarify Karpenter instance profile name input (waht to name it) … 

    …vs output (the name of the profile created or existing)
    @bryantbiggs
    bryantbiggs committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6292fed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/override-instance-profile-name

    @bryantbiggs
    bryantbiggs committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d98f892 View commit details
    Browse the repository at this point in the history