Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update crossplane aws provider location #1150

Merged
merged 12 commits into from
Nov 10, 2022

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

Fixes an issue where Crossplane AWS Provider fails when it is enabled. The cause seems to be a change in the location of the upstream provider package within dockerhub as mentioned in the latest release notes. This PR updates the location to Upbound Marketplace which seems to be a better location that DockerHub.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 9, 2022 06:37 Inactive
@askulkarni2 askulkarni2 changed the title Fix crossplane aws provider fix: Update crossplane aws provider location Nov 9, 2022
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 9, 2022 06:53 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 9, 2022 07:01 Inactive
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 10, 2022 00:38 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 10, 2022 03:11 Inactive
@vara-bonthu
Copy link
Contributor

@askulkarni2 Plan workflow is failing for Crossplane otherwise we can merge this PR.

@bryantbiggs bryantbiggs merged commit 7082a63 into main Nov 10, 2022
@bryantbiggs bryantbiggs deleted the fix-crossplane-aws-provider branch November 10, 2022 20:33
@timblaktu
Copy link

@askulkarni2 I'm curious why has the crossplane example been moved into a separate dedicated repo over at awslabs? Was is just deemed too unstable?

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossplane aws provider deployment fails
4 participants