Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use kubernetes-provider from eks-blueprints #59

Merged

Conversation

askulkarni2
Copy link
Contributor

@askulkarni2 askulkarni2 commented Nov 9, 2022

What does this PR do?

  1. Updates Terraform bootstrap to use the newly added kubernetes-provider in the eks-blueprints crossplane add-on module.
  2. Updates versions of providers used to latest.
  3. Some minor code refactor so bootstrap look similar to EKS Blueprints examples.

Motivation

Use upstream features and fix issues faced during deployment of the AWS provider.

Resolves aws-ia/terraform-aws-eks-blueprints#1149

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Also see aws-ia/terraform-aws-eks-blueprints#1150

Test

NAME                                                READY   STATUS    RESTARTS        AGE
aws-provider-e0b33d016bb8-c744d4b9d-k9gg6           1/1     Running   0               34m
crossplane-68f7f8bc86-njchq                         1/1     Running   1 (6h43m ago)   21h
crossplane-rbac-manager-69ff585d75-jjqrs            1/1     Running   1 (6h43m ago)   21h
kubernetes-provider-a1a49ab74384-64b5787bd5-x5f9f   1/1     Running   1 (6h43m ago)   21h

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@vara-bonthu vara-bonthu merged commit 90a2561 into awslabs:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossplane aws provider deployment fails
2 participants