Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable EKS Worker Dedicated Tenancy #1388

Merged
merged 16 commits into from
Feb 11, 2023
Merged

Conversation

ntwkninja
Copy link
Contributor

@ntwkninja ntwkninja commented Jan 30, 2023

Afford the option to use dedicated tenancy for EKS workers in self managed node group

Motivation

Required by org policy to use dedicated tenancy where possible

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@ntwkninja ntwkninja requested a review from a team as a code owner January 30, 2023 18:37
@ntwkninja ntwkninja changed the title Enable EKS Worker Dedicated Tenancy feat: Enable EKS Worker Dedicated Tenancy Jan 31, 2023
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 @ntwkninja May I ask if you are using this feature in production with self-managed add-ons?

@ntwkninja
Copy link
Contributor Author

LGTM 👍🏼 @ntwkninja May I ask if you are using this feature in production with self-managed add-ons?

Currently a development effort that we're actively working.

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test February 11, 2023 00:43 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 20d6c47 into aws-ia:main Feb 11, 2023
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request Mar 17, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dedicated tenancy option for EKS workers
3 participants