Update opentelemetry-lambda sub module #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasireddy99
changed the title
bryan-aguilar
previously approved these changes
Apr 29, 2024
bryan-aguilar
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates open telemetry lambda sub module
I am patching the otel java agent and java contrib dependencies to 1.32.0 for now, because 2.0 adot java agent is not available/released.
context - the ADOT Java agent version
1.32.1includes a dependency on OpenTelemetry SDK version 1.34.1 and the fix related tolambda semantic changes - awsxray propogator to priorotize the xray env variable is present in 1.34.0 otel-java-contrib version, but follow up fix for xray trace span linking is in otel-java-intrumentation - 2.3.0.
To use the latest java dependencies .
This would require a bump to 2.0 -
otel-java-instrumentationmajor version upgrade in adot-java-agent, once the ADOT java agent 2.x is available, patches can also be removed. hence we are choosing to stay at 1.32.0 version for java dependencies.Another option if we have to use 1.32.1
adot-java-agent1.32.1- otel-java-instrumentation.otel-java-instrumentationpatched package in step 1.1.34.0inopentelemetry-lambda- java module and use patched aws-otel-instrumentation in step 2.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.