-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AWS Active Tracing span linking #10930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Mar 22, 2024
...src/main/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AbstractAwsLambdaTest.java
Show resolved
Hide resolved
tylerbenson
force-pushed
the
tyler/xray-lambda
branch
from
March 22, 2024 17:33
4fe88a7
to
d6da5b0
Compare
laurit
approved these changes
Mar 22, 2024
FYI @rapphil |
3 tasks
github-actions
bot
added
the
test native
This label can be applied to PRs to trigger them to run native tests
label
Mar 27, 2024
I think if you rebase (and pull in #10969) it should fix the license check |
This aligns with the latest spec change: open-telemetry/semantic-conventions#354 Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
tylerbenson
force-pushed
the
tyler/xray-lambda
branch
from
March 29, 2024 16:57
e8f1a23
to
7d56c0c
Compare
Any more blockers here? |
we'll merge it before |
rapphil
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with the latest spec change:
open-telemetry/semantic-conventions#354
Providing the Lambda span's parent context should continue to be the responsibility of the global propagator.
Related: open-telemetry/opentelemetry-java-contrib#1032