-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify patches and update sub module #908
Conversation
go/build.sh
Outdated
@@ -9,4 +9,5 @@ popd || exit | |||
# Build sample app | |||
|
|||
cd ../opentelemetry-lambda/go/sample-apps/function || exit | |||
go get github.com/golang/protobuf@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this resolves the protobuf failure in workflow - protocolbuffers/protobuf#16163,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the PR to include sub module changes, instead of modifying the build script.
Description:
Update Otel lambda submodule
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.