-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.33.0 of google.golang.org/protobuf Fails to Compile #16163
Comments
Happens also to me with Go 1.21.6 |
# go get github.com/golang/protobuf@latest
go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead.
go: upgraded github.com/golang/protobuf v1.5.2 => v1.5.4 |
Happening to me too |
Looks like this isn't a bug, but just a breaking change that requires a manual update of the |
Can confirm, bumping |
Since it seems to work for multiple people, I'll close this issue. |
…8996) * build(deps): bump google.golang.org/protobuf from 1.28.0 to 1.33.0 Bumps google.golang.org/protobuf from 1.28.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * go get github.com/golang/protobuf@latest -- see protocolbuffers/protobuf#16163 * go mod tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jesse Amano <jesse.amano@hpe.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…3429) * chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * manual bump: protocolbuffers/protobuf#16163 Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
What version of protobuf and what language are you using?
Version: N/A (indirect dependency)
Language: GoLang
What operating system (Linux, Windows, ...) and version?
Linux/MacOS
What runtime / compiler are you using (e.g., python version or gcc version)
Go 1.20.12
What did you do?
Steps to reproduce the behavior:
Update the version of google.golang.org/protobuf in go.mod to v1.33.0. Run go build. Build fails due to undefined constant in the package.
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
Upon inspection of the source, it would appear that the offending constant
descriptorpb.Default_FileOptions_PhpGenericServices
is indeed not defined in v1.33.0 and so it is failing to compile.Anything else we should know about your project / environment
n/a
The text was updated successfully, but these errors were encountered: