Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.33.0 of google.golang.org/protobuf Fails to Compile #16163

Closed
Jac0bDeal opened this issue Mar 14, 2024 · 6 comments
Closed

v1.33.0 of google.golang.org/protobuf Fails to Compile #16163

Jac0bDeal opened this issue Mar 14, 2024 · 6 comments

Comments

@Jac0bDeal
Copy link

Jac0bDeal commented Mar 14, 2024

What version of protobuf and what language are you using?
Version: N/A (indirect dependency)
Language: GoLang

What operating system (Linux, Windows, ...) and version?
Linux/MacOS

What runtime / compiler are you using (e.g., python version or gcc version)
Go 1.20.12

What did you do?
Steps to reproduce the behavior:

Update the version of google.golang.org/protobuf in go.mod to v1.33.0. Run go build. Build fails due to undefined constant in the package.

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).

# github.com/golang/protobuf/protoc-gen-go/descriptor
../../../go/pkg/mod/github.com/golang/protobuf@v1.5.3/protoc-gen-go/descriptor/descriptor.pb.go:106:61: undefined: descriptorpb.Default_FileOptions_PhpGenericServices

Upon inspection of the source, it would appear that the offending constant descriptorpb.Default_FileOptions_PhpGenericServices is indeed not defined in v1.33.0 and so it is failing to compile.

Anything else we should know about your project / environment
n/a

@orius123
Copy link

Happens also to me with Go 1.21.6

@yuanyp8
Copy link

yuanyp8 commented Mar 15, 2024

# go get github.com/golang/protobuf@latest 
go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead.
go: upgraded github.com/golang/protobuf v1.5.2 => v1.5.4

@dosten
Copy link

dosten commented Mar 15, 2024

Happening to me too

@Jac0bDeal
Copy link
Author

Looks like this isn't a bug, but just a breaking change that requires a manual update of the github.com/golang/protobuf indirect dependency in go.mod:
flipt-io/flipt#2841 (comment)

@markphelps
Copy link

Can confirm, bumping github.com/golang/protobuf to 1.5.4 allows this this change to compile. https://github.com/flipt-io/flipt/pull/2855/files

@Jac0bDeal
Copy link
Author

Since it seems to work for multiple people, I'll close this issue.

jesse-amano-hpe added a commit to determined-ai/determined that referenced this issue Mar 22, 2024
jesse-amano-hpe added a commit to determined-ai/determined that referenced this issue Mar 22, 2024
…8996)

* build(deps): bump google.golang.org/protobuf from 1.28.0 to 1.33.0

Bumps google.golang.org/protobuf from 1.28.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* go get github.com/golang/protobuf@latest

  -- see protocolbuffers/protobuf#16163

* go mod tidy

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jesse Amano <jesse.amano@hpe.com>
movsb added a commit to movsb/taoblog that referenced this issue Mar 28, 2024
zachaller added a commit to argoproj/argo-rollouts that referenced this issue Apr 1, 2024
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller added a commit to argoproj/argo-rollouts that referenced this issue Apr 1, 2024
…3429)

* chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0

Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0

Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* manual bump: protocolbuffers/protobuf#16163

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants